Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify: add MsgTimeout #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

identify: add MsgTimeout #19

wants to merge 1 commit into from

Conversation

yields
Copy link

@yields yields commented Mar 24, 2017

This PR will let clients configure their own msg_timeout:

c, err := nsq.StartConsumer(nsq.ConsumerConfig{
  Identify: nsq.Identify{MsgTimeout: time.Second * 5},
})

If MsgTimeout is not passed, the behavior should be the same.

@yields yields requested a review from achille-roussel March 24, 2017 19:20
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@achille-roussel
Copy link
Contributor

Looks like you have these tests failing:

=== RUN   TestConsumer

=== RUN   TestConsumer/test-consumer-1

=== RUN   TestConsumer/test-consumer-10

=== RUN   TestConsumer/test-consumer-100

=== RUN   TestConsumer/test-consumer-1000

--- FAIL: TestConsumer (0.00s)

    --- FAIL: TestConsumer/test-consumer-1 (10.11s)

    	consumer_test.go:69: timeout

    --- FAIL: TestConsumer/test-consumer-1000 (10.64s)

    	consumer_test.go:69: timeout

    --- FAIL: TestConsumer/test-consumer-100 (10.15s)

    	consumer_test.go:69: timeout

    --- FAIL: TestConsumer/test-consumer-10 (10.12s)

    	consumer_test.go:69: timeout

=== RUN   TestRequeue

2017/03/25 00:50:29 GET http://localhost:4163?topic=test-requeue: 404 Not Found {"message":"TOPIC_NOT_FOUND"}; GET http://localhost:4165?topic=test-requeue: 404 Not Found {"message":"TOPIC_NOT_FOUND"}

--- FAIL: TestRequeue (10.01s)

	consumer_test.go:117: timeout

I triggered a rebuilt and it happened again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants