Clang-tidy fixes for Common++ #1639
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1639 +/- ##
=======================================
Coverage 83.34% 83.35%
=======================================
Files 276 276
Lines 48086 48092 +6
Branches 9721 9707 -14
=======================================
+ Hits 40078 40085 +7
+ Misses 7116 7113 -3
- Partials 892 894 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@egecetin please see this comment: #1637 (comment) |
Dimi1010
reviewed
Nov 14, 2024
| @@ -21,4 +21,5 @@ BreakBeforeBraces: Custom | |||
| BraceWrapping: | |||
| SplitEmptyFunction: false | |||
| AfterCaseLabel: true | |||
| QualifierAlignment: Left | |||
There was a problem hiding this comment.
RIP, const on the right... I found that easier to read because its consistent behavior with its usage in the middle...
There was a problem hiding this comment.
Copilot reviewed 3 out of 21 changed files in this pull request and generated no suggestions.
Files not reviewed (18)
- Common++/header/GeneralUtils.h: Language not supported
- Common++/header/IpAddress.h: Language not supported
- Common++/header/IpUtils.h: Language not supported
- Common++/header/LRUList.h: Language not supported
- Common++/header/Logger.h: Language not supported
- Common++/header/MacAddress.h: Language not supported
- Common++/header/OUILookup.h: Language not supported
- Common++/header/PointerVector.h: Language not supported
- Common++/header/SystemUtils.h: Language not supported
- Common++/header/TablePrinter.h: Language not supported
- Common++/src/GeneralUtils.cpp: Language not supported
- Common++/src/IpAddress.cpp: Language not supported
- Common++/src/IpUtils.cpp: Language not supported
- Common++/src/Logger.cpp: Language not supported
- Common++/src/MacAddress.cpp: Language not supported
- Common++/src/OUILookup.cpp: Language not supported
- Common++/src/SystemUtils.cpp: Language not supported
- Common++/src/TablePrinter.cpp: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various clang-tidy warnings