Fixed issue where scripts are downloaded twice #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original script was making 2x requests to server due to `_loadScript` setting the `src` attribute of the `<script>` element ... as it turns out you can recursively call `requireScript` from `_cacheScript` and eat your own dog food. This kills 2 birds with one stone, it doesnt double load content on the first pass, and it shrinks the total size of the script itself because `_loadScript` can be deleted I also made the script AMD compatible It should be noted that removing `_loadScript` breaks backwards compatibility for browsers that do not support local-storage though I plan on adding this functionality back into the `requireScript` function along with some code to specifically check if the browser supports local storage.
|
Hey there, I did not forget this, but I had no time so far. Will get to this soon hopefully. Thanks already 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.