Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to KEEP configs unchanged on the environment #75

Merged

Conversation

vpodorozh
Copy link
Contributor

@vpodorozh vpodorozh commented Mar 19, 2024

Allow to KEEP configs unchanged on the environment => Base config will not override configs that are already set on environment, in case we use "!!KEEP" directive.

This is needed in stations when you have couple test environments, that share same test credentials. By utilizing this feature you could keep test credentials be stored under base scope, but on production scope you just add "!!KEEP" value to not override production configurations.
This would add a significant possibility to decrease configs duplications.

Example

Setup before changes

dev1:
- config/abc/key: "qwerty"

dev2:
- config/abc/key: "qwerty"

staging1:
- config/abc/key: "qwerty"

staging2:
- config/abc/key: "qwerty"

test_env1:
- config/abc/key: "qwerty"

test_env2:
- config/abc/key: "qwerty"

Setup after changes

base:
- config/abc/key: "qwerty"

production:
- config/abc/key: "!!KEEP"

…ll not override configs that are already set on environment.
@vpodorozh vpodorozh changed the title Allow to KEEP configs unchanged on the environemnt Allow to KEEP configs unchanged on the environment Mar 19, 2024
@therouv
Copy link
Contributor

therouv commented Mar 19, 2024

@vpodorozh Thank you! Can you please fix the CS violations and also document the new behavior in the import documentation?

I'll take a look at the unit tests. That seems to be some other issue.

Thanks! Happy to merge after you've updated the PR 😊

@vpodorozh
Copy link
Contributor Author

@vpodorozh Thank you! Can you please fix the CS violations and also document the new behavior in the import documentation?

I'll take a look at the unit tests. That seems to be some other issue.

Thanks! Happy to merge after you've updated the PR 😊

@therouv - done. Let me know in case smth needs to be fixed.
Thank you!

@therouv therouv merged commit a779440 into semaio:main Apr 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants