-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(conventional-changelog-presets): supported new preset format #519
Conversation
BREAKING CHANGE: the new preset format is a breaking change when compared to the previous preset format. updating to support the new format means that the old preset format is no longer supported. update your preset to the latest version to maintain compatibility
so far, this updates the conventional-changelog presets and adjusts loading to handle the new format.
|
…ional-changelog expectations based on conventional-changelog/conventional-changelog#1121 (comment). however, assuming the previous order actually aligned with how core provides the list, this will need to be coordinated with reversing that list somewhere
got the integration test passing by reversing the list of commits to match the conventional-changelog expectations based on conventional-changelog/conventional-changelog#1121 (comment). however, assuming the previous order actually aligned with how core provides the list, this will need to be coordinated with reversing that list somewhere |
loadedConfig = await (typeof loadedConfig === "function" | ||
? isPlainObject(presetConfig) | ||
? loadedConfig(presetConfig) | ||
: promisify(loadedConfig)() | ||
: loadedConfig); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see additional explanation at semantic-release/release-notes-generator#526 (comment)
} else if (config) { | ||
loadedConfig = importFrom.silent(__dirname, config) || importFrom(cwd, config); | ||
loadedConfig = await (importFrom.silent(__dirname, config) || importFrom(cwd, config))(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…opped v19 support BREAKING CHANGE: the minimum required node version is now v18.17, v19 support has been dropped, and the minimum required in the v20 range is v20.6.1
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: the new preset format is a breaking change when compared to the previous preset format. updating to support the new format means that the old preset format is no longer supported. update your preset to the latest version to maintain compatibility
closes #525