Update version numbers etc for v5.4.0

.VERSION

@@ -1 +1 @@
-5.3.7
+5.4.0

.clang-format

@@ -45,7 +45,6 @@ ConstructorInitializerIndentWidth: 4
 ContinuationIndentWidth: 4
 Cpp11BracedListStyle: true
 DerivePointerAlignment: false
-PointerAlignment: PAS_Left
 DisableFormat:   false
 ExperimentalAutoDetectBinPacking: false
 FixNamespaceComments: true

.mailmap

@@ -1,3 +1,4 @@
+Marina Anagnostopoulou-Merkouri <marina.anagnostopoulou-merkouri@bristol.ac.uk> Marina Anagnostopoulou-Merkouri <mam49@st-andrews.ac.uk>
 Stuart Burrell <stuartburrell1994@gmail.com> <stuartburrell@users.noreply.github.com>
 Stuart Burrell <stuartburrell1994@gmail.com> stuartburrell <unknown>
 Reinis Cirpons <rc234@st-andrews.ac.uk> Reinis Cirpons <43414125+reiniscirpons@users.noreply.github.com>
@@ -8,8 +9,10 @@ Joseph Edwards <jde1@st-andrews.ac.uk> Joe Edwards <80713360+Joseph-Edwards@user
 Joseph Edwards <jde1@st-andrews.ac.uk> Joseph Edwards <josephdavidedwards@gmail.com>
 Luke Elliott <le27@st-andrews.ac.uk> le27 <le27@st-andrews.ac.uk>
 Fernando Flores Brito <ffloresbrito@gmail.com> Fernando Flores Brito <ffb3@st-andrews.ac.uk>
+Tillman Froehlich <trf1@st-andrews.ac.uk> <47321884+awesometillman@users.noreply.github.com>
 Nick Ham <nicholas.charles.ham@gmail.com>
-Robert Hancock <hancock@informatik.uni-heidelberg.de> Robert Hancock <unknown>
+Robert Hancock <robert.hancock@maths.ox.ac.uk> Robert Hancock <hancock@informatik.uni-heidelberg.de>
+Robert Hancock <robert.hancock@maths.ox.ac.uk> Robert Hancock <unknown>
 Max Horn <horn@mathematik.uni-kl.de> Max Horn <max@quendi.de>
 Chris Jefferson <caj21@st-andrews.ac.uk> Chris Jefferson <chris@bubblescope.net>
 Julius Jonusas <j.jonusas@gmail.com> Julius <jj252@st-andrews.ac.uk>
@@ -19,6 +22,7 @@ Olexandr Konovalov <obk1@st-andrews.ac.uk> Alexander Konovalov <alex-konovalov@u
 Olexandr Konovalov <obk1@st-andrews.ac.uk> Alexander Konovalov <alexk@mcs.st-andrews.ac.uk>
 Olexandr Konovalov <obk1@st-andrews.ac.uk> Olexandr Konovalov <5751387+olexandr-konovalov@users.noreply.github.com>
 Artemis Konstantinidi <ak316@st-andrews.ac.uk> artemiskonst <97620468+artemiskonst@users.noreply.github.com>
+Hyeokjun Kwon <hk78@st-andrews.ac.uk> Hyeokjun Kwon <rnjsgurwns27@gmail.com>
 James Mitchell <jdm3@st-andrews.ac.uk> <jdm3@st-and.ac.uk>
 James Mitchell <jdm3@st-andrews.ac.uk> <jdm3@st-andrews.ac.uk>
 James Mitchell <jdm3@st-andrews.ac.uk> <jenkyfunds@gmail.com>
@@ -39,6 +43,7 @@ Chris Wensley <cdwensley.maths@btinternet.com> cdwensley <cdwensley.maths@btinte
 Murray Whyte <mw231@st-andrews.ac.uk> Murray Whyte <42549861+MTWhyte@users.noreply.github.com>
 Wilf Wilson <gap@wilf-wilson.net> Wilf Wilson <wilf@wilf-wilson.net>
 Wilf Wilson <gap@wilf-wilson.net> wilfwilson <wilf@wilf-wilson.net>
+Tianrun Yang <ty39@st-andrews.ac.uk> Tianrun Yang <117233646+Tianrun-Y@users.noreply.github.com>
 Michael Young <mct25@st-andrews.ac.uk> <mct25@st-andrews.ac.uk>
 Michael Young <mct25@st-andrews.ac.uk> <mtorpey@mtorpey-debtest>
 Michael Young <mct25@st-andrews.ac.uk> mct25 <unknown>

CHANGELOG.md

@@ -3,6 +3,23 @@ Copyright © 2011-2024 [James D. Mitchell][] et al.
 
 Licensing information can be found in the `LICENSE` file.
 
+## Version 5.4.0 (released 19/10/2024)
+
+## What's Changed
+
+* Improved IsIsomorphicSemigroup Method by @awesometillman in https://github.com/semigroups/Semigroups/pull/1023
+* fix typo in nambooripad partial order documentation by @Tianrun-Y in https://github.com/semigroups/Semigroups/pull/1030
+* Better kernel module checking by @Joseph-Edwards in https://github.com/semigroups/Semigroups/pull/1032
+* Fix ChooseHashFunction rank issue. by @reiniscirpons in https://github.com/semigroups/Semigroups/pull/1035
+* kernel: Semigroups can be used in GAP on julia by @james-d-mitchell in https://github.com/semigroups/Semigroups/pull/1036
+* Use LoadKernelExtension for gapbind_demo by @fingolfin in https://github.com/semigroups/Semigroups/pull/1039
+
+## New Contributors
+* @awesometillman made their first contribution in https://github.com/semigroups/Semigroups/pull/1023
+* @Tianrun-Y made their first contribution in https://github.com/semigroups/Semigroups/pull/1030
+
+**Full Changelog**: https://github.com/semigroups/Semigroups/compare/v5.3.7...v5.4.0
+
 ## Version 5.3.7 (released 11/03/2024)
 
 This is a minor release with some changes for compatibility with GAP.

GNUmakefile.in

@@ -101,7 +101,7 @@ lint:
 	etc/cpplint.sh
 
 format:
-	clang-format -i src/*.[hc]
+	clang-format -i src/*.*pp
 
 .PHONY: lint format
 

PackageInfo.g

@@ -34,8 +34,8 @@ _STANDREWSCS := Concatenation(["Jack Cole Building, North Haugh, ",
 SetPackageInfo(rec(
 PackageName := "Semigroups",
 Subtitle := "A package for semigroups and monoids",
-Version := "5.3.7",
-Date := "11/03/2024",  # dd/mm/yyyy format
+Version := "5.4.0",
+Date := "19/10/2024",  # dd/mm/yyyy format
 License := "GPL-3.0-or-later",
 
 ArchiveFormats := ".tar.gz",
@@ -71,11 +71,10 @@ Persons := [
     FirstNames    := "Marina",
     IsAuthor      := true,
     IsMaintainer  := false,
-    Email         := "mam49@st-andrews.ac.uk",
-    PostalAddress := _STANDREWSMATHS,
-    Place         := "St Andrews",
-    Institution   := "University of St Andrews",
-    WWWHome       := "https://github.com/marinaanagno"),
+    Email         := "marina.anagnostopoulou-merkouri@bristol.ac.uk",
+    Place         := "Bristol",
+    Institution   := "University of Bristol",
+    WWWHome       := "https://marinaanagno.github.io"),
 
   rec(
     LastName      := "Breuer",
@@ -149,8 +148,14 @@ Persons := [
     FirstNames    := "Fernando",
     IsAuthor      := true,
     IsMaintainer  := false,
-    Email         := "ffloresbrito@gmail.com",
-    WWWHome       := "https://github.com/ffloresbrito"),
+    Email         := "ffloresbrito@gmail.com"),
+
+  rec(
+    LastName      := "Froehlich",
+    FirstNames    := "Tillman",
+    IsAuthor      := true,
+    IsMaintainer  := false,
+    Email         := "trf1@st-andrews.ac.uk"),
 
   rec(
     LastName      := "Ham",
@@ -167,7 +172,7 @@ Persons := [
     FirstNames    := "Robert",
     IsAuthor      := true,
     IsMaintainer  := false,
-    Email         := "hancock@informatik.uni-heidelberg.de",
+    Email         := "robert.hancock@maths.ox.ac.uk",
     WWWHome       := "https://sites.google.com/view/robert-hancock/"),
 
   rec(
@@ -210,11 +215,7 @@ Persons := [
     LastName      := "Nagpal",
     FirstNames    := "Chinmaya",
     IsAuthor      := true,
-    IsMaintainer  := false,
-    Email         := "chinmaya1011@gmail.com",
-    PostalAddress := _STANDREWSMATHS,
-    Place         := "St Andrews",
-    Institution   := "University of St Andrews"),
+    IsMaintainer  := false),
 
   rec(
     LastName      := "Konovalov",
@@ -231,11 +232,13 @@ Persons := [
     LastName      := "Konstantinidi",
     FirstNames    := "Artemis",
     IsAuthor      := true,
-    IsMaintainer  := false,
-    Email         := "ak316@st-andrews.ac.uk",
-    PostalAddress := _STANDREWSMATHS,
-    Place         := "St Andrews",
-    Institution   := "University of St Andrews"),
+    IsMaintainer  := false),
+
+  rec(
+    LastName      := "Kwon",
+    FirstNames    := "Hyeokjun",
+    IsAuthor      := true,
+    IsMaintainer  := false),
 
   rec(
     LastName      := "Pasechnik",
@@ -257,7 +260,7 @@ Persons := [
     IsAuthor      := true,
     IsMaintainer  := false,
     Email         := "markus.pfeiffer@morphism.de",
-    WWWHome       := "https://www.morphism.de/~markusp/"),
+    WWWHome       := "https://markusp.morphism.de/"),
 
   rec(
     LastName      := "Russell",
@@ -295,8 +298,7 @@ Persons := [
     LastName      := "Spiers",
     FirstNames    := "Ben",
     IsAuthor      := true,
-    IsMaintainer  := false,
-    Email         := "bspiers972@outlook.com"),
+    IsMaintainer  := false),
 
   rec(
     LastName      := "Thiéry",
@@ -344,6 +346,12 @@ Persons := [
      Email         := "gap@wilf-wilson.net",
      WWWHome       := "https://wilf.me"),
 
+   rec(
+     LastName      := "Yang",
+     FirstNames    := "Tianrun",
+     IsAuthor      := true,
+     IsMaintainer  := false),
+
    rec(
      LastName      := "Young",
      FirstNames    := "Michael",

VERSIONS

@@ -9,6 +9,7 @@
 ##
 ##
 
+release 5.4.0  - 19/10/2024
 release 5.3.7  - 11/03/2024
 release 5.3.6  - 19/02/2024
 release 5.3.5  - 14/02/2024

etc/cpplint.sh

@@ -1,4 +1,4 @@
 #!/bin/bash
 set -e
 
-cpplint src/*.hpp src/*.h src/*.cpp
+cpplint src/*.*pp

release.toml

@@ -1,4 +1,6 @@
 [authors]
-expired_emails = ["cr66@st-andrews.ac.uk"]
+expired_emails = ["cr66@st-andrews.ac.uk", "ak316@st-andrews.ac.uk",
+    "bspiers972@outlook.com", "chinmaya1011@gmail.com",
+    "hk78@st-andrews.ac.uk", "ty39@st-andrews.ac.uk"]
 author_files = ["PackageInfo.g"]
 ignore = ["convert-repo", "dependabot"]

src/CPPLINT.cfg

@@ -1,5 +1,5 @@
 set noparent
-filter=-build/c++11,-build/c++14,-build/include_subdir,-runtime/indentation_namespace,-runtime/references,-readability/todo
+filter=-build/c++11,-build/c++14,-build/include_subdir,-runtime/indentation_namespace,-runtime/references,-readability/todo,-whitespace/indent_namespace
 linelength=80
 root=../..
 exclude_files=(semigroups-config.hpp|pkgconfig.h)

src/bipart.cpp

@@ -1210,7 +1210,7 @@ Obj BLOCKS_INV_RIGHT(Obj self, Obj blocks_gap, Obj x_gap) {
         continue;
       }
     }
-    if (junk == (uint32_t) -1) {
+    if (junk == static_cast<uint32_t>(-1)) {
       junk = next;
       next++;
     }

src/froidure-pin-base.cpp

@@ -16,6 +16,8 @@
 // along with this program.  If not, see <https://www.gnu.org/licenses/>.
 //
 
+#include <memory>  // for std::shared_ptr
+
 // Semigroups GAP package headers
 #include "to_cpp.hpp"  // for to_cpp
 #include "to_gap.hpp"  // for to_gap

src/pkg.cpp

@@ -428,10 +428,8 @@ static StructGVarFilt GVarFilts[] = {
 
 typedef Obj (*GVarFunc)(/*arguments*/);
 
-#define GVAR_ENTRY(srcfile, name, nparam, params)                 \
-  {                                                               \
-#name, nparam, params, (GVarFunc) name, srcfile ":Func" #name \
-  }
+#define GVAR_ENTRY(srcfile, name, nparam, params) \
+  {#name, nparam, params, (GVarFunc) name, srcfile ":Func" #name}
 
 // Table of functions to export