Apply suggestions from code review

semigroups · Mar 11, 2024 · 917be05 · 917be05
1 parent 708e4c1
commit 917be05
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/doc/semicons.xml b/doc/semicons.xml
@@ -151,7 +151,7 @@ true]]></Example>
   <ManSection>
     <Func Name="FreeSemilattice" Arg="[filt, ] n"/>
     <Returns>
-      A free semilattice of <A>n</A> generators.
+      A free semilattice with <A>n</A> generators.
     </Returns>
     <Description>
       If <A>n</A> is a positive integer, then this function returns a free

diff --git a/gap/semigroups/semicons.gi b/gap/semigroups/semicons.gi
@@ -419,8 +419,7 @@ function(arg...)
     filter := arg[1];
     n := arg[2];
   else
-    ErrorNoReturn("the arguments must be a positive integer or a filter ",
-                  "and a positive integer");
+    ErrorNoReturn("expected 2 arguments found ", Length(arg));
   fi;
 
   if not IsPosInt(n) or not IsOperation(filter) then
@@ -431,16 +430,6 @@ function(arg...)
   S := FreeSemilatticeCons(filter, n);
 
   SetSize(S, 2 ^ n - 1);
-  # SetIsRectangularBand(S, true);
-  # SetNrRClasses(S, m);
-  # SetNrLClasses(S, n);
-  # if m <> 1 or n <> 1 then
-  #   SetIsGroupAsSemigroup(S, false);
-  #   SetIsZeroSemigroup(S, false);
-  #   SetIsTrivial(S, false);
-  # fi;
-  # SetIsRightZeroSemigroup(S, m = 1);
-  # SetIsLeftZeroSemigroup(S, n = 1);
 
   return S;
 end);