Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GAP coverage script newline issue #1029

Merged

Conversation

reiniscirpons
Copy link
Collaborator

This PR fixes the GAP coverage script on certain platforms. The issue seems to be caused by feeding raw \n newlines into gap, as a fix we add non-raw newlines after the _GAP_COMMANDS are created.

Once accepted, these changes should also be propagated to the Digraphs package, since it uses an identical script.

@reiniscirpons
Copy link
Collaborator Author

As an aside, what is the --open parameter used for in the script? I thought it was a flag which would open the overall coverage index.html my browser, but it seems like it takes a file and outputs a link to the specific coverage for that file (with a specific reference to a missing line if the coverage contains a missed line).

@james-d-mitchell james-d-mitchell added the development Label for issues/pr related to development of the package label Aug 21, 2024
@james-d-mitchell
Copy link
Collaborator

Thanks @reiniscirpons

@james-d-mitchell james-d-mitchell merged commit ff54965 into semigroups:main Aug 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Label for issues/pr related to development of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants