Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/InlineEdit and InlineInput a11y docs #1527

Merged
merged 12 commits into from
Aug 9, 2024

Conversation

j-mnizhek
Copy link
Contributor

Motivation and Context

Made small updates to InlineEdit and InlineInput documentation:

  • some accessibility fixes
  • illustration fixes for InlineEdit
  • fixes for code examples

How has this been tested?

Locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly or it's not required.
  • Unit tests are not broken.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new unit tests on added of fixed functionality.

Copy link
Contributor

@sheila-semrush sheila-semrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few suggestions

website/docs/components/inline-edit/inline-edit.md Outdated Show resolved Hide resolved
website/docs/components/inline-edit/inline-edit-a11y.md Outdated Show resolved Hide resolved
website/docs/components/inline-edit/inline-edit-a11y.md Outdated Show resolved Hide resolved
website/docs/components/inline-edit/inline-edit-a11y.md Outdated Show resolved Hide resolved
website/docs/components/inline-edit/inline-edit-code.md Outdated Show resolved Hide resolved
website/docs/components/inline-edit/inline-edit.md Outdated Show resolved Hide resolved
website/docs/components/inline-input/inline-input-a11y.md Outdated Show resolved Hide resolved
website/docs/components/inline-input/inline-input-a11y.md Outdated Show resolved Hide resolved
website/docs/components/inline-input/inline-input-a11y.md Outdated Show resolved Hide resolved
@sheila-semrush sheila-semrush self-requested a review August 5, 2024 12:33
Copy link
Contributor

@sheila-semrush sheila-semrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

j-mnizhek and others added 11 commits August 8, 2024 14:07
Co-authored-by: Sheila <166654065+sheila-semrush@users.noreply.github.com>
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
Co-authored-by: Sheila <166654065+sheila-semrush@users.noreply.github.com>
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
Co-authored-by: Sheila <166654065+sheila-semrush@users.noreply.github.com>
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
…t.tsx

Co-authored-by: Sheila <166654065+sheila-semrush@users.noreply.github.com>
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
Co-authored-by: Sheila <166654065+sheila-semrush@users.noreply.github.com>
Signed-off-by: Julia Mnizhek <77798437+j-mnizhek@users.noreply.github.com>
@msereniti msereniti force-pushed the update/inline-edit-a11y-docs branch from 62e9210 to 5bac6e4 Compare August 8, 2024 12:10
@j-mnizhek j-mnizhek merged commit 627d9f8 into master Aug 9, 2024
8 of 9 checks passed
@j-mnizhek j-mnizhek deleted the update/inline-edit-a11y-docs branch August 9, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants