Fix homebrew setup on ubuntu runners

.github/workflows/main.yml

@@ -23,9 +23,9 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v4
       - name: Install BATS
-        run: "[[ -f /usr/local/bin/bats ]] && brew unlink bats || true ; brew install bats-core"
+        run: "[[ -f /home/linuxbrew/.linuxbrew/bin/brew ]] && eval \"$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)\" || true ;  [[ -f /usr/local/bin/bats ]] && brew unlink bats || true ; brew install bats-core"
       - name: Run BATS tests
-        run: bats tests/
+        run: "[[ -f /home/linuxbrew/.linuxbrew/bin/brew ]] && eval \"$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)\" || true ; bats tests/"
   test-on-container-debian-ubuntu:
     runs-on: ubuntu-latest
     container: ${{ matrix.container }}
@@ -34,7 +34,8 @@ jobs:
         container: ["ubuntu:22.04", "ubuntu:20.04", "ubuntu:18.04", "debian:12-slim", "debian:11-slim", "debian:10-slim"]
     steps:
       - name: Check out code
-        uses: actions/checkout@v4
+        # use v3 for glibc compatibility with ubuntu:18.04
+        uses: actions/checkout@v3
       - name: Install dependencies and BATS
         run: "apt-get update && apt-get install -y openssl curl file bats xxd"
       - name: Run BATS tests

README.md

@@ -170,7 +170,7 @@ The format is based on [Keep a Changelog][kac] and this project adheres to [Sema
 
 ## Contributing
 
-Pull requests are welcome. The unit tests are written with https://github.com/bats-core/bats-core. Make use of the excellent tool `shellcheck` (https://www.shellcheck.net/). Run with `shellcheck -x -a aws-micro`.
+Pull requests are welcome. The unit tests are written with https://github.com/bats-core/bats-core. Run with `bats tests/`. Make use of the excellent tool `shellcheck` (https://www.shellcheck.net/). Run with `shellcheck -x -a aws-micro`.
 
 ## License
 

s3.sh

@@ -33,6 +33,7 @@ s3_ls() {
   request_url="$(create_request_url "${service}" ls "${_arg_endpoint_url}" "${region}" "${bucket}" "${key}")"
 
   if [[ "${_arg_no_sign_request}" = "on" ]]; then
+    # shellcheck disable=SC2086
     ${dryrun} curl ${curl_output} --fail "${request_url}" | "${formatter}"
   else
     headers=("host:$(get_host_from_request_url "$request_url")" "x-amz-content-sha256:${content_sha256}" "x-amz-date:${date}" "${security_token_header:-}")
@@ -95,9 +96,11 @@ Error: Invalid argument type"  #  or <S3Uri> <S3Uri> (not yet implemented)
 
   if [[ "${_arg_no_sign_request}" = "on" ]]; then
     if [[ "${http_method}" == "PUT" ]]; then
+      # shellcheck disable=SC2086
       ${dryrun} curl ${curl_output} --fail -X "${http_method}" "${request_url}" --data-binary "@${source}" -o /dev/null
       echo "upload: ${source} to s3://${bucket}/${key}"
     else
+      # shellcheck disable=SC2086
       ${dryrun} curl ${curl_output} --fail "${request_url}" -o "${destination}"
       echo "download: ${source} to ${destination}"
     fi

s3api.sh

@@ -17,6 +17,7 @@ s3api_create-bucket() {
   request_url="$(create_request_url "${service}" "" "${_arg_endpoint_url}" "${region}" "${bucket}" "")"
 
   if [[ "${_arg_no_sign_request}" = "on" ]]; then
+      # shellcheck disable=SC2086
       ${dryrun} curl ${curl_output} --fail -X "${http_method}" "${request_url}" -H "Content-Length: 0" -o /dev/null
   else
     headers=("host:$(get_host_from_request_url "$request_url")" "x-amz-content-sha256:${content_sha256}" "x-amz-date:${date}" "${security_token_header:-}")

sts.sh

@@ -15,6 +15,7 @@ sts_assume-role() {
   content_sha256="$(sha256 "${body}")"
 
   if [[ "${_arg_no_sign_request}" = "on" ]]; then
+      # shellcheck disable=SC2086
       ${dryrun} curl ${curl_output} --fail "${request_url}" --data "${body}"
   else
     headers=("host:$(get_host_from_request_url "$request_url")" "x-amz-date:${date}" "content-type:application/x-www-form-urlencoded;charset=utf-8" "${security_token_header:-}")

utils.sh

@@ -81,7 +81,7 @@ md5_base64() {
 
 sha256_hmac() {
   declare -r sig="$1"
-  openssl sha256 -mac HMAC -macopt "$sig" -hex | sed 's/.*(stdin)= //'
+  openssl sha256 -mac HMAC -sha256 -macopt "$sig" -hex | sed 's/.*(stdin)= //'
 }
 
 sha256() {