get app running locally #332
Conversation
| "hooks": { | ||
| "pre-commit": "lint-staged" | ||
| } | ||
| "hooks": {} |
There was a problem hiding this comment.
Removed husky hook for the time being
| @@ -7,9 +7,9 @@ module.exports = { | |||
| }, | |||
| extends: [ | |||
| "react-app", | |||
| "airbnb", | |||
There was a problem hiding this comment.
ESLint was causing errors. It's very outdated so for now, we'll work without a full eslint config.
| enum SemesterLength { | ||
| Full = "Full", | ||
| HalfFirst = "First", | ||
| HalfSecond = "Second", | ||
| IntensiveA = "A", | ||
| IntensiveB = "B", | ||
| IntensiveC = "C", | ||
| IntensiveD = "D", | ||
| } | ||
|
|
||
| enum Term { | ||
| Fall = "FA", | ||
| Spring = "SP", | ||
| // eslint-disable-next-line typescript-sort-keys/string-enum | ||
| Interim = "IN", // TODO: Remove? | ||
| Summer = "SU", | ||
| } | ||
|
|
||
|
|
||
| /* Used for containing the global state of the app | ||
| and a dispatcher to perform updates against the | ||
| state of the app. | ||
| */ | ||
| export const AppContext = createContext<AppContext>({ | ||
| appDispatch: voidFn, | ||
| appState: initialAppState, | ||
| appState: { | ||
| classes: [], | ||
| colorBy: 0, | ||
| constraints: {}, | ||
| departments: [], |
There was a problem hiding this comment.
For the time being, this is duplicated.
|
Tests faill because of switching to PNPM |
|
Thanks for this, Charles. Alas, we've been buried with summer projects and the new MDS program going live next month. We will be fielding a Schedulizer student team in early September, so hopefully we'll have some time to resurrect this system and review your proposed changes. |
|
Roger that. I can verify my changes work and merge them in. That way there's no hassle for the students this fall. |
|
@charkour - I'm finally coming back around to this issue and am having trouble getting the system running locally. I haven't done active development on this system for a while, so I'm probably forgetting some key steps. I verified that I've got Node 18.17.1; NPM 10.0.0; PNPM 8.6.0 on WSL2 Linux, and then I tried running the system on both the production and then the fix-local branches.
(naive?) question: is npm-install and then npm-start the right way to start the local server? |
Yup! I ran into that too. This branch aims to fix those issues.
The ESLint errors should be fixable, so you'll need to do that quickly. The console will display what needs to be updated. The correct way to run this is running the commands |
|
Please feel free to push to this branch. I cannot confidently commit time to dev work, but I'll advise as possible. |
|
Thanks - I'm not familiar with pnpm. |
remove Harmony update About with Team 2023's information
Hi @kvlinden and @rpruim. I have some free time this summer, so I'd like to modernize and improve the third-party dependencies for this project so you and the students can more easily add features in the future. If you'd like to talk in more detail, please email me. Thank you
First order of business is to actually run the app locally with modern a modern JS runtime (Node v18)
This fixes bugs to allow the app to run locally with Node v18 and PNPM v8. This updates FullCalendar to v6 to fix some vdom issues.
To update to Node v18, use Node Version Manager
To use pnpm, follow their docs
Many of the updates were due to ESLint rule changes and auto-formatting.