Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update scheduling format #349

Merged
merged 15 commits into from
Apr 9, 2024
Merged

Feature/update scheduling format #349

merged 15 commits into from
Apr 9, 2024

Conversation

NycoCC1993
Copy link
Collaborator

Merging Sophia's schedule import updates to the package repair update

@SophiaSun18
Unused capacity-related sections removed
e4e6228
@SophiaSun18
Term -> Academic Period
ab2efa5
@SophiaSun18
Department -> Parse the first piece of CourseSection
b329e50
@SophiaSun18
Prefix, Number, Section, Course Title -> Parse everything from Course…
514183e 
… Section, but didn't comment out previous cf functions
@SophiaSun18
Faculty Hours, Student Hours -> Semester Hours
8272656
@SophiaSun18
BuildingAndRoom -> Location 1 & 2, Using the same cf function but onl…
7f51ba2 
…y creating meeting sections for 1
@SophiaSun18
Meeting Day, Meeting Time -> Meeting Patterns
7d7cd72
@SophiaSun18
Split part of original courseSectionCallback() into courseCallback()
bc2efe3 
to fix the error of "cannot read properties of undefined"
@SophiaSun18
SemesterStartDate, SemesterEndDate -> StartDate, EndDate
ade7977 
original StartDate (column name: TermStart) commented out: same value as SemesterStartDate, all combined into the StartDate column of new format
Semester Length = EndDate - StartDate
@SophiaSun18
Fixed readFullCSV.spec.ts to pass pnpm test using updated example…
0652709 
… schedule
@SophiaSun18
Fixed minor meetingTime issue to accomodate the most recent schedule
a81da0f
@SophiaSun18
Update meetingPatternCallback() and timeCallback() to process section…
1ecd2c2 
…s with multiple meeting times
@SophiaSun18
Update output format
452f775
@SophiaSun18
Update testing script
3ba0a47
@SophiaSun18
Update deploy.yml for production deployment
9d31bdc
@NycoCC1993 NycoCC1993 merged commit 6f61efc into update/develop Apr 9, 2024
1 check passed
@NycoCC1993 NycoCC1993 deleted the feature/update-scheduling-format branch April 9, 2024 20:13
@SophiaSun18 SophiaSun18 requested review from kvlinden and rpruim April 10, 2024 00:46
@kvlinden
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvlinden kvlinden Awaiting requested review from kvlinden

@rpruim rpruim Awaiting requested review from rpruim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NycoCC1993 @kvlinden @SophiaSun18