Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): add Hydreon RG-15 rainsensor #802

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

(feat): add Hydreon RG-15 rainsensor #802

wants to merge 12 commits into from

Conversation

Thiemann96
Copy link
Contributor

Added a template for the new rain sensor. In total the sensor produces 3 phenomena

  • Rain intensity
  • Rain accumulation (total; since the moment the sensor was first powered)
  • Rain accumulation (event; the amount of rain that has fallen during the most recent rain event)

@mpfeil mpfeil changed the title Add rainsensor Add Hydreon RG-15 rainsensor Sep 7, 2023
@mpfeil mpfeil added this to the v11.2.0 milestone Sep 7, 2023
@mpfeil mpfeil added the feature label Sep 7, 2023
mpfeil
mpfeil requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@mpfeil mpfeil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prefix everything that starts with rain_ with the sensor type rg15 to identify different rain sensors in the future.

Also change the file names in sensorDefinitions to rg15_rain_intensity and so on.

@mpfeil mpfeil changed the title Add Hydreon RG-15 rainsensor (feat): add Hydreon RG-15 rainsensor Sep 7, 2023
@mpfeil mpfeil removed this from the v11.2.0 milestone Oct 11, 2023
@mpfeil mpfeil added this to the v12.0.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpfeil mpfeil mpfeil requested changes

Assignees

@Thiemann96 Thiemann96

Labels
feature
Projects
None yet
Milestone
v12.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Thiemann96 @mpfeil