Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chakram #830

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Remove chakram #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
979fba1
Remove chakram
mpfeil Oct 2, 2023
e9347f4
First new tests
mpfeil Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"@turf/invariant": "^6.5.0",
"chai": "^4.3.10",
"chai-http": "^4.4.0",
"chakram": "^1.5.0",
"cheerio": "^1.0.0-rc.6",
"csv-parse": "^4.15.4",
"eslint": "7.26.0",
Expand Down
56 changes: 40 additions & 16 deletions tests/tests/00-cors-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,35 +2,59 @@

/* global describe it */

const chakram = require('chakram'),
expect = chakram.expect;
const chai = require('chai');
const chaiHttp = require('chai-http');
const expect = chai.expect;

chai.use(chaiHttp);

const BASE_URL = process.env.OSEM_TEST_BASE_URL;

describe('openSenseMap API CORS test', function () {
it('should always send out CORS headers', function () {
return chakram.get(BASE_URL)
.then(function (response) {
it('should always send out CORS headers', function (done) {
chai.request(BASE_URL)
.get('/')
.end(function (err, response) {
expect(response).status(200);
expect(response).to.have.header('access-control-allow-origin', '*');
expect(response).to.have.header('access-control-allow-methods', 'GET, OPTIONS');
expect(response).to.have.header('access-control-allow-headers', /authorization/i);
expect(response).to.have.header('access-control-expose-headers', /content-disposition/i);
expect(response).to.have.header(
'access-control-allow-methods',
'GET, OPTIONS'
);
expect(response).to.have.header(
'access-control-allow-headers',
/authorization/i
);
expect(response).to.have.header(
'access-control-expose-headers',
/content-disposition/i
);

return chakram.wait();
done();
});
});

it('should send out CORS headers for preflight requests', function () {
return chakram.options(BASE_URL, { headers: { 'access-control-request-method': 'post' } })
.then(function (response) {
it('should send out CORS headers for preflight requests', function (done) {
chai.request(BASE_URL)
.options('/')
.set('access-control-request-method', 'post')
.end(function (err, response) {
expect(response).status(204);
expect(response).to.have.header('access-control-allow-origin', '*');
expect(response).to.have.header('access-control-allow-methods', 'POST, OPTIONS');
expect(response).to.have.header('access-control-allow-headers', /authorization/i);
expect(response).to.have.header('access-control-expose-headers', /content-disposition/i);
expect(response).to.have.header(
'access-control-allow-methods',
'POST, OPTIONS'
);
expect(response).to.have.header(
'access-control-allow-headers',
/authorization/i
);
expect(response).to.have.header(
'access-control-expose-headers',
/content-disposition/i
);

return chakram.wait();
done();
});
});
});
24 changes: 14 additions & 10 deletions tests/tests/000-root-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,25 @@

/* global describe it */

const chakram = require('chakram'),
expect = chakram.expect;
const chai = require('chai');
const chaiHttp = require('chai-http');
const expect = chai.expect;

chai.use(chaiHttp);

const BASE_URL = process.env.OSEM_TEST_BASE_URL;

describe('openSenseMap API Routes: /', function () {
it('should print available routes', function () {
return chakram.get(BASE_URL)
.then(function (response) {
expect(response).status(200);
expect(response).to.have.header('content-type', 'text/plain; charset=utf-8');

expect(response.body).not.empty;
it('should print available routes', function (done) {
chai.request(BASE_URL)
.get('/')
.end(function (err, res) {
expect(err).to.be.null;
expect(res).to.have.status(200);
expect(res).to.have.header('content-type', 'text/plain; charset=utf-8');
expect(res.body).not.null;

return chakram.wait();
done();
});
});
});
104 changes: 61 additions & 43 deletions tests/tests/001-stats-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,82 +1,100 @@
'use strict';

/* global describe it before */
/* global describe it */

const chakram = require('chakram'),
expect = chakram.expect;
const chai = require('chai');
const chaiHttp = require('chai-http');
const expect = chai.expect;

const BASE_URL = `${process.env.OSEM_TEST_BASE_URL}/stats`,
options = { headers: { 'x-apicache-bypass': true } };
chai.use(chaiHttp);

describe('openSenseMap API Routes: /stats', function () {
let request, requestHumanTrue, requestHumanFalse, requestHumanWrong1, requestHumanWrong2;
before(function () {
request = chakram.get(BASE_URL, options);
requestHumanTrue = chakram.get(`${BASE_URL}?human=true`, options);
requestHumanFalse = chakram.get(`${BASE_URL}?human=false`, options);
requestHumanWrong1 = chakram.get(`${BASE_URL}?human=tr`, options);
requestHumanWrong2 = chakram.get(`${BASE_URL}?human=fulse`, options);
});
const BASE_URL = `${process.env.OSEM_TEST_BASE_URL}`;
const options = { headers: { 'x-apicache-bypass': true } };
const ROUTE = '/stats';

it('should return a json array with three numbers', function () {
return request
.then(function (response) {
describe('openSenseMap API Routes: /stats', function () {
it('should return a json array with three numbers', function (done) {
chai.request(BASE_URL)
.get(ROUTE)
.set(options.headers)
.end(function (err, response) {
expect(response).status(200);
expect(response).to.have.header('content-type', 'application/json; charset=utf-8');
expect(response).to.have.header(
'content-type',
'application/json; charset=utf-8'
);

expect(response.body).not.empty;

expect(Array.isArray(response.body)).true;

expect(response.body.every(n => typeof n === 'number')).true;
expect(response.body.every((n) => typeof n === 'number')).true;

return chakram.wait();
done();
});
});

it('should return a json array with three strings when called with parameter human=true', function () {
return requestHumanTrue
.then(function (response) {
it('should return a json array with three strings when called with parameter human=true', function (done) {
chai.request(BASE_URL)
.get(ROUTE)
.set(options.headers)
.query({ human: true })
.end(function (err, response) {
expect(response).status(200);
expect(response).to.have.header('content-type', 'application/json; charset=utf-8');
expect(response).to.have.header(
'content-type',
'application/json; charset=utf-8'
);

expect(response.body).not.empty;

expect(Array.isArray(response.body)).true;

expect(response.body.every(n => typeof n === 'string')).true;
expect(response.body.every((n) => typeof n === 'string')).true;

return chakram.wait();
done();
});
});

it('should return a json array with three numbers when called with parameter human=false', function () {
return requestHumanFalse
.then(function (response) {
it('should return a json array with three numbers when called with parameter human=false', function (done) {
chai.request(BASE_URL)
.get(ROUTE)
.set(options.headers)
.query({ human: false })
.end(function (err, response) {
expect(response).status(200);
expect(response).to.have.header('content-type', 'application/json; charset=utf-8');
expect(response).to.have.header(
'content-type',
'application/json; charset=utf-8'
);

expect(response.body).not.empty;

expect(Array.isArray(response.body)).true;

expect(response.body.every(n => typeof n === 'number')).true;
expect(response.body.every((n) => typeof n === 'number')).true;

return chakram.wait();
done();
});
});

it('should return an error if parameter human is not true or false', function () {
return chakram.all([requestHumanWrong1, requestHumanWrong2])
.then(function (responses) {
for (const response of responses) {
expect(response).status(422);
expect(response).to.have.header('content-type', 'application/json; charset=utf-8');

expect(response).to.have.json('message', 'Illegal value for parameter human. allowed values: true, false');
}

return chakram.wait();
it('should return an error if parameter human is not true or false', function (done) {
chai.request(BASE_URL)
.get(ROUTE)
.set(options.headers)
.query({ human: 'tr' })
.end(function (err, response) {
expect(response).status(422);
expect(response).to.have.header(
'content-type',
'application/json; charset=utf-8'
);
expect(response).to.be.json;
expect(response.body).to.have.a.property('message');
expect(response.body.message).to.equal(
'Illegal value for parameter human. allowed values: true, false'
);
done();
});
});
});
Loading
Loading