Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Metrics #137

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

serglom21
Copy link
Contributor

Description

Add custom metrics to the Android demo app. These replicate the same metrics that were added to our react service here

  • products_request.duration
  • checkout.click
  • checkout.error
  • checkout.success

@sdzhong
Copy link
Contributor

sdzhong commented May 1, 2024

Hey @serglom21 , can you please share sample events or their metrics for this PR?

@serglom21
Copy link
Contributor Author

Ah yeah, totally!

I do see something not working as expected with the products_request.duration metric, where the description for that span is not showing up - I will check on that with the team and follow up!

Screenshot 2024-05-03 at 8 34 42 AM

@sdzhong sdzhong mentioned this pull request May 3, 2024
@serglom21
Copy link
Contributor Author

Mhmm things are not fully working as expected here. Not necessarily because of the code introduced on this PR but rather because of this issue that happens with our demo data.

I would want to wait until that issue gets addressed by our engineers before merging this. I will follow up in the next couple of days

@sdzhong
Copy link
Contributor

sdzhong commented May 21, 2024

Hey @serglom21

I do see something not working as expected with the products_request.duration metric, where the description for that span is not showing up - I will check on that with the team and follow up!

This should be fixed in https://github.com/getsentry/sentry-java/releases/tag/7.8.0, (4.5.0 of the gradle plugin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants