[Ready for review] V0 initial improvements to performance data for demo #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstavitsky
commented
Nov 1, 2021
| @@ -13,5 +13,13 @@ module.exports = { | |||
| inlineRequires: true, | |||
| }, | |||
| }), | |||
| minifierConfig: { | |||
There was a problem hiding this comment.
This exists so that we don't get profiled components showing up as unknown in spans.
cstavitsky
force-pushed
the
v0_initial_improvements_to_performance_data_for_demo
branch
from
1e6beca
to
4d70c72
Compare
thinkocapo
reviewed
Nov 11, 2021
| @@ -171,6 +171,9 @@ const ProductItem = (props: { | |||
| imgcropped: string; | |||
| appDispatch: AppDispatch; | |||
| }): React.ReactElement => { | |||
| React.useEffect(() => { | |||
| fetch(`${BACKEND_URL}/success`) // exists just to add span data to demo | |||
thinkocapo
approved these changes
Nov 11, 2021
| /* You could wrap this with the Sentry Profiler, | ||
| * but then you'd have hundreds/thousands of spans because the tools response is not paginated. | ||
| */ | ||
| const ProfiledImage = Sentry.withProfiler(Image); |
There was a problem hiding this comment.
This helps me remember the Profiler was used, as I go through the rest of this file. Sweet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react.updatespans -- working on that separately)react.updatespans showing. The plan is to move forward with what we have now (screenshot below) and then addreact.updatespans once we figure that out.