[Deserialize] Split out peek logic from seed generic #1102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
reviewed
Oct 19, 2024
Co-authored-by: David Tolnay <dtolnay@gmail.com>
dtolnay
reviewed
Oct 19, 2024
There was a problem hiding this comment.
Thanks for the PR.
I think extracting a peek_next_elem function that is shared between SeqAccess and MapAccess is going to be counterproductive because it interferes with making more of the logic independent of the seed type. This PR is still leaving a significant amount of logic that is duplicated for each seed, as opposed to once per Read type.
Check out #1205 for a different approach that produces 25% smaller next_element_seed and next_key_seed functions compared to this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits duplicated and somewhat complex logic depending on two generics (
Readandseed) into only depending on one generic (Read) cutting debug mode llvm-lines output on my program by:SeqAccess::next_element_seed: 34232 -> 21752MapAccess::next_key_seed: 11225 -> 6722