Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward serde_json::value::RawValue to serde_json::RawValue #1211

Closed

Conversation

bheylin
Copy link

@bheylin bheylin commented Nov 8, 2024

Given that Value is in the root of the crate I argue that RawValue should be at the same level.

I use RawValue even more than I use Value and I would like to see it promoted, even if that just means
making the import more inviting to use.

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I would prefer to be pretty selective about what goes in the crate root. Needing RawValue more often than Value is not typical.

@dtolnay dtolnay closed this Nov 8, 2024
@bheylin
Copy link
Author

bheylin commented Nov 8, 2024

Thanks for the PR. I would prefer to be pretty selective about what goes in the crate root. Needing RawValue more often than Value is not typical.

All good, it was worth a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants