refactor(settings): improve validation for excluded profiles

sereneblue · May 9, 2020 · 0a76fb7 · 0a76fb7
1 parent 2668bc1
commit 0a76fb7
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/src/lib/chameleon.ts b/src/lib/chameleon.ts
@@ -920,16 +920,15 @@ export class Chameleon {
         msg,
       };
     } else {
-      if (!impSettings.excluded.every(p => profileIds.includes(p))) {
-        msg = browser.i18n.getMessage('options-import-invalid-excludedProfile');
+      let excludedProfiles = [];
 
-        return {
-          error :  true,
-          msg,
-        };
-      } else {
-        s.excluded = impSettings.excluded;
+      for (let p of impSettings.excluded) {
+        if (profileIds.includes(p)) {
+          excludedProfiles.push(p);
+        }
       }
+
+      s.excluded = excludedProfiles;
     }
 
     if (!impSettings.ipRules) {