Fix lambda function analysis #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1025,11 +1025,19 @@ def visit_UnaryOp(self, node): | |||
| def visit_Lambda(self, node, step=DeclarationStep): | |||
| if step is DeclarationStep: | |||
| dnode = self.chains.setdefault(node, Def(node)) | |||
| for default in node.args.defaults: | |||
There was a problem hiding this comment.
While reading this I realize that we also don't visit argument annotations for lambda in case of future_annotations.
What do you think of aggregating the behavior of lambda and functiondef analysis in a helper function?
There was a problem hiding this comment.
Lambda functions don't have annotations.
What do you think of aggregating the behavior of lambda and functiondef analysis in a helper function?
I think it's not worth it.
There was a problem hiding this comment.
Well it would have avoided this patch ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67.
This also fixes a bug in the
Lambda.args.defaultshandling.