Removing "sha256:" prefix in hash values returned by docker's runner …

…inspect command. (mlcommons#318)
sergey-serebryakov · Jul 24, 2023 · daccf94 · daccf94
1 parent 3b3fffc
commit daccf94
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/runners/mlcube_docker/mlcube_docker/docker_run.py b/runners/mlcube_docker/mlcube_docker/docker_run.py
@@ -376,4 +376,7 @@ def inspect(self, force: bool = False) -> t.Dict:
  f"Unexpected output from `{' '.join(docker_inspect_cmd)}`. Expected a list of dicts of length 1."
  )
 
- return {"hash": image_info[0].get("Id", None)}
+ image_id: str = image_info[0].get("Id", None)
+ if image_id and image_id.startswith("sha256:"):
+ image_id = image_id[7:]
+ return {"hash": image_id}
diff --git a/runners/mlcube_docker/mlcube_docker/tests/test_docker_runner.py b/runners/mlcube_docker/mlcube_docker/tests/test_docker_runner.py
@@ -32,7 +32,7 @@ class TestDockerRunner(TestCase):
  def _check_inspect_output(self, info: t.Dict) -> None:
  self.assertIsInstance(info, dict)
  self.assertIn("hash", info)
- self.assertTrue(info["hash"].startswith("sha256:"))
+ self.assertFalse(info["hash"].startswith("sha256:"))
 
  @staticmethod
  def noop(*args, **kwargs) -> None: