Chart not supported by Deck Builder #74
Conversation
| @@ -331,8 +331,6 @@ internal static void AddRelationships(OpenXmlPart oldPart, OpenXmlPart newPart, | |||
| var newRid = Relationships.GetNewRelationshipId(); | |||
| var oldHyperlink = oldPart.HyperlinkRelationships.FirstOrDefault(h => h.Id == relId); | |||
| if (oldHyperlink is null) { | |||
| //TODO Issue with reference to another part: var temp = oldPart.GetPartById(relId); | |||
| RemoveContent(newContent, e.Name, relId); | |||
There was a problem hiding this comment.
This case is interesting... We copy hyperlinks relationships and cannot find hyperlinks inside the source document by it is relId.
The code assumes that the link is broken and removes the relationship from the target file. Can you create new slide manually from scratch that triggers this if statement during slide publishing?
| @@ -204,7 +206,6 @@ private void CopyPresentationParts(PresentationDocument sourceDocument) | |||
| { | |||
| var newPart = _newDocument.PresentationPart.AddNewPart<PresentationPropertiesPart>(); | |||
| var xd1 = presentationPropertiesPart.GetXDocument(); | |||
| xd1.Descendants(P.custShow).Remove(); | |||
There was a problem hiding this comment.
Why?
This element specifies a custom show which is an ordered list of a group of slides that are contained within the presentation. The custom show element allows for the specification of a presentation order that is different from the order in which the slides themselves are stored.
| { | ||
| switch (oldPartIdPair.OpenXmlPart) | ||
| if (oldChart.Parts.FirstOrDefault(p => p.RelationshipId == relId) is { } oldPartIdPair) |
There was a problem hiding this comment.
let's extract oldChart.Parts.FirstOrDefault(p => p.RelationshipId == relId) into variable and combine 2 if conditions into one
No description provided.