Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize workflows #24

Closed
wants to merge 6 commits into from
Closed

Optimize workflows #24

wants to merge 6 commits into from

Conversation

steveiliop56
Copy link
Contributor

Just optimized the workflow a bit (a lot)

@sergi0g
Copy link
Owner

sergi0g commented Sep 1, 2024

Wow, great job @steveiliop56! I am terrible at writing Github Action! I'd like 2 more things:

  1. There is no need to run a release build in the CI. It would also be very helpful to set up sccache for Cross to ensure faster builds.
  2. The build binary CI job failed (https://github.com/sergi0g/cup/actions/runs/10655334162/job/29533707445#step:5:267). Please fix the error.

@steveiliop56
Copy link
Contributor Author

Hello @sergi0g,

I decided not to use cross in the CI as it makes things slower and its not really needed, I instead used cargo build --verbose to just build cup to make sure that it works, I guess that eliminates the need for cache since its already quite fast. I also fixed the mv command because apparently I forgot to add ./ so it moves it to the current directory. Hope everything is good!

@sergi0g
Copy link
Owner

sergi0g commented Sep 2, 2024

@steveiliop56 great work! Don't worry about the workflows failing! I'll need to modify the workflow a bit because building Cup now requires the build.sh script instead of cargo build. I'll need to modify the Dockerfile too! Thank you so much for this PR!

@steveiliop56
Copy link
Contributor Author

Hello @sergi0g,

I updated quite a lot of stuff including your build script and Dockerfile to make building easier and also make the code more understandable with some comments. Hope it's ok!

@sergi0g
Copy link
Owner

sergi0g commented Sep 3, 2024

@steveiliop56 thank you for your work! I really appreciate the fact that you devoted your time to make DX better.

I want to make a few small changes, so I'll take over from here. Thanks again!

@steveiliop56
Copy link
Contributor Author

No problem have fun!

@sergi0g sergi0g mentioned this pull request Sep 6, 2024
@sergi0g sergi0g closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants