Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unwanted side cases from prefix checks #5

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

BurningWitness
Copy link
Collaborator

@BurningWitness BurningWitness commented Sep 2, 2024

  • Tightened up prefix checks, removing impossible side cases where a downstream prefix is equal to the prefix above, with or without the masking bit.

  • Fixed Data.Zebra.Word.fillRange, which broke the aforementioned checks, producing malformed trees in cases like the following:

    fillRange (Range 10 20) White . fillRange (Range 30 40) White $ Mono Black
    
    Bin 00000000000000000000000000000000000000000000000000000000001XXXXX
      Bin 0000000000000000000000000000000000000000000000000000000000011XXX
        Bin 000000000000000000000000000000000000000000000000000000000001XXXX
          Tip 0000000000000000000000000000000000000000000000000000000000001010 => W -- Misplaced
          Tip 0000000000000000000000000000000000000000000000000000000000010101 => B
        Tip 0000000000000000000000000000000000000000000000000000000000011110 => W
      Tip 0000000000000000000000000000000000000000000000000000000000101001 => B
  • Version bump to 1.0.0.2.

@BurningWitness BurningWitness merged commit 6ffd42f into master Sep 8, 2024
7 checks passed
@BurningWitness BurningWitness deleted the tighter-prefix-checks branch September 8, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant