Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/meta db filter #46

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Feat/meta db filter #46

merged 2 commits into from
Sep 27, 2023

Conversation

tarkah
Copy link
Collaborator

@tarkah tarkah commented Sep 27, 2023

No description provided.

ikeycode
ikeycode approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ikeycode ikeycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our matrix chat - despite this potentially having some minimal overhead in single-provider scenarios - it locks down to a cleaner API and lays the groundwork for search APIs, etc.

It's also more memory efficient by returning less vectors

@ikeycode ikeycode merged commit e46d179 into main Sep 27, 2023
@ikeycode ikeycode deleted the feat/meta-db-filter branch September 27, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikeycode ikeycode ikeycode approved these changes

@ermo ermo Awaiting requested review from ermo ermo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarkah @ikeycode