Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/prune #60

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Feat/prune #60

merged 2 commits into from
Oct 19, 2023

Conversation

tarkah
Copy link
Collaborator

@tarkah tarkah commented Oct 18, 2023

No description provided.

@tarkah tarkah changed the base branch from main to feat/request-file October 18, 2023 21:59
Need to commit "remove" transaction before prune
will pickup any files to garbage collect
@tarkah tarkah changed the base branch from feat/request-file to feat/more-remove October 18, 2023 22:08
@tarkah tarkah marked this pull request as ready for review October 19, 2023 17:57
@tarkah tarkah requested review from ikeycode and ermo as code owners October 19, 2023 17:57
Base automatically changed from feat/more-remove to main October 19, 2023 20:18
@@ -102,11 +102,11 @@ impl Registry {
}

/// Return a new transaction for this registry initialised with the incoming package set as installed
pub async fn transaction_with_packages(
pub async fn transaction_with_installed(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

}

fn display_column(&self, writer: &mut impl Write, col: pretty::Column, width: usize) {
let right_gap = matches!(col, pretty::Column::Last)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheeky trick :D

@ikeycode ikeycode merged commit 0df3886 into main Oct 19, 2023
@ikeycode ikeycode deleted the feat/prune branch October 19, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants