Skip to content

Commit

Permalink
Release 1.0.1-alpha.10 - Fixed component setup from addon to app
Browse files Browse the repository at this point in the history
Add missing bowerrc

Allows installing bower components after clone

Fix component setup from addon to app

New setup allows using the same template for multiple component names.
This fixes the `{{new-version-notifier}}` not working previously, since
it didn't have a template (it needed a template with it's own name). This
fix allows one template to be used for both.

Also added a simple test in the dummy app with a VERSION.txt

Add missing bowerrc

Allows installing bower components after clone

Fix component setup from addon to app

New setup allows using the same template for multiple component names.
This fixes the `{{new-version-notifier}}` not working previously, since
it didn't have a template (it needed a template with it's own name). This
fix allows one template to be used for both.

Also added a simple test in the dummy app with a VERSION.txt
  • Loading branch information
Ilya Radchenko authored and Seth Webster committed Dec 28, 2015
1 parent c50aac3 commit f3c4a83
Show file tree
Hide file tree
Showing 9 changed files with 19 additions and 9 deletions.
4 changes: 4 additions & 0 deletions .bowerrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"directory": "bower_components",
"analytics": false
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
/*jshint esnext:true */

import Ember from 'ember';
import layout from './template';

export default Ember.Component.extend({
layout: layout,
updateInterval: 60000, // One Minute Default
tagName: "div",
versionFileName: "/VERSION.txt",
Expand Down
4 changes: 2 additions & 2 deletions app/components/ember-cli-new-version.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import Ember from 'ember';
import EmberCliNewVersion from 'ember-cli-new-version/components/ember-cli-new-version';
export default EmberCliNewVersion;
import NewVersionNotifier from 'ember-cli-new-version/components/new-version-notifier/component';
export default NewVersionNotifier;
4 changes: 2 additions & 2 deletions app/components/new-version-notifier.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*jshint esnext:true */

import Ember from 'ember';
import EmberCliNewVersion from 'ember-cli-new-version/components/ember-cli-new-version';
export default EmberCliNewVersion;
import NewVersionNotifier from 'ember-cli-new-version/components/new-version-notifier/component';
export default NewVersionNotifier;
Empty file removed app/templates/application.hbs
Empty file.
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"name": "ember-cli-new-version",
"version": "1.0.1-alpha.9",
"version": "1.0.1-alpha.10",
"description": "A convention based update notification for Ember. With this addon, you can detect a new version and notify the user to refresh the page",
"directories": {
"doc": "doc",
"test": "tests"
},
"scripts": {
"build": "ember build",
"start": "ember server",
"start": "ember server --live-reload=false",
"test": "ember try:testall"
},
"repository": {
Expand All @@ -26,7 +26,6 @@
"ember-cli-app-version": "^1.0.0",
"ember-cli-content-security-policy": "0.4.0",
"ember-cli-dependency-checker": "^1.1.0",
"ember-cli-htmlbars": "^1.0.1",
"ember-cli-htmlbars-inline-precompile": "^0.3.1",
"ember-cli-ic-ajax": "0.2.4",
"ember-cli-inject-live-reload": "^1.3.1",
Expand All @@ -48,9 +47,10 @@
"new version"
],
"dependencies": {
"ember-cli-babel": "^5.1.5"
"ember-cli-babel": "^5.1.5",
"ember-cli-htmlbars": "^1.0.1"
},
"ember-addon": {
"configPath": "tests/dummy/config"
}
}
}
3 changes: 3 additions & 0 deletions tests/dummy/app/templates/application.hbs
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
<h2 id="title">Welcome to Ember</h2>

{{outlet}}

{{ember-cli-new-version}}
{{new-version-notifier}}
1 change: 1 addition & 0 deletions tests/dummy/public/VERSION.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1.0.5

0 comments on commit f3c4a83

Please sign in to comment.