Fix signatures II #143
Merged
Fix signatures II #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smradCZ
previously approved these changes
Jun 3, 2024
OpatrilPeter
force-pushed
the
fix_signatures
branch
from
119d5ed
to
e9630f0
Compare
OpatrilPeter
force-pushed
the
fix_signatures
branch
from
e9630f0
to
f3b7196
Compare
Explicit type MYSQL_ROW_OFFSET is important - as exactly this type is required as argument for coupled function seekRowOffset.
Replacement is RowIndex_t which is more specific and no longer private.
Function sendLongData was misleading, as it implied return of some form of error code.
OpatrilPeter
force-pushed
the
fix_signatures
branch
from
f3b7196
to
e8f7b2e
Compare
|
I've encounter issues with obsolete mysql 5.7 image used for testing. I've tested that modern images mariadb:10.3.39-focal and mysql:8.0.39-debian work correctly, but choosing which way we'll go is left for future work. Please review the relevant commit before merge. |
Upgrade implicit image from mysql 5.7 to 8.0, allow customization via TEST_MYSQL_DOCKER_IMAGE environment variable.
OpatrilPeter
force-pushed
the
fix_signatures
branch
from
e8f7b2e
to
666051f
Compare
|
We've had an internal team discussion, the plan is to go ahead and upgrade the image to modern mysql. I've added an experimental customization option, the environmental variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #70