Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bazel version checks for dev versions #128

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 13, 2023

No description provided.

@fmeum fmeum requested a review from sgammon as a code owner September 13, 2023 07:59
Signed-off-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 13, 2023

@sgammon One more missing piece, without this change Bazel's bootstrap test (and really any dev version) fails when it uses the ruleset.

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sgammon sgammon merged commit 3b204f7 into sgammon:main Sep 13, 2023
61 checks passed
@fmeum fmeum deleted the fix-version-usage branch September 14, 2023 06:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants