Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use_param_file for args that are too long for windows #131

Closed
wants to merge 0 commits into from

Conversation

ruwi-next
Copy link
Contributor

Hey, firstly thanks for making this project.

I am using it on windows and was running into an issue where the command used to invoke native-image was too long for windows. It turns out graalvm added support for args files here graalvm/native-build-tools#205 and it wasn't too hard to add support for them here.

Thanks
Ruairidh

Copy link
Owner

@sgammon sgammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, and thank you for your contribution 😄

Let's see if CI passes; if everything looks good, I can fixup your commit to pass the other checks. If you'd like to do so:

  1. format it like fix(windows): add use_param_file for long command lines
  2. commit with --signoff so that it passes the DCO check

Otherwise I suspect it will pass

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sgammon
Copy link
Owner

sgammon commented Sep 13, 2023

Oh no! @ruwi-next, I'm very sorry. I was trying to clean up your commit here, and I accidentally pushed an even branch with main; that caused it to close the PR because the branch was even, and then I couldn't fix it because of branch protections on your fork 😞

I've opened an alternate PR with your changes at #132, and kept you as the commit author so you can be listed in the contributors. Sorry for the mishap! I've been using Git for literally decades now and it still catches me every now and then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants