Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update skylib to fix Bazel version check for dev builds instead #204

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 12, 2023

This reverts commit 3b204f7 and instead resolves the problem by updating skylib.

This reverts commits 3b204f7 and
204516e and instead resolves the
problem by updating skylib.

Signed-off-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Copy link

sonarcloud bot commented Dec 12, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@fmeum
Copy link
Collaborator Author

fmeum commented Dec 12, 2023

@sgammon Not sure what's up with the macOS build, looks like some kind of authentication failure.

@sgammon
Copy link
Owner

sgammon commented Dec 12, 2023

@fmeum could be our build cache? I've updated my key; let me try a re-run.

@fmeum
Copy link
Collaborator Author

fmeum commented Dec 12, 2023

@sgammon Thanks, tests are passing now.

@sgammon
Copy link
Owner

sgammon commented Dec 12, 2023

Sounds good. Feel free to merge when ready.

@fmeum fmeum merged commit 7ffd78a into sgammon:main Dec 12, 2023
60 checks passed
@fmeum fmeum deleted the fix-version branch December 12, 2023 19:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants