Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bin suffix for shared library targets #217

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Conversation

sgammon
Copy link
Owner

@sgammon sgammon commented Jan 1, 2024

  • fix: use dylib postfix for shared library outputs on mac
  • fix: use so postfix for shared library outputs on linux
  • fix: consolidate bin postfix exe with new behavior

Closes: #216

@sgammon sgammon added bug Something isn't working native-image Features and issues relating to the Native Image tool platform:darwin Issues relating to macOS platform:windows Issues relating to Windows and MSVC platform:linux Issues and features relating to Linux labels Jan 1, 2024
@sgammon sgammon added this to the 1.0.0 milestone Jan 1, 2024
@sgammon sgammon self-assigned this Jan 1, 2024
@sgammon sgammon changed the title fix: bin postfix for shared library targets fix: bin suffix for shared library targets Jan 1, 2024
- fix: use `dylib` postfix for shared library outputs on mac
- fix: use `so` postfix for shared library outputs on linux
- fix: consolidate bin postfix `exe` with new behavior
- test: add integration test for shared libs on all platforms

Closes: #216
Signed-off-by: Sam Gammon <sam@elide.ventures>
Copy link

sonarcloud bot commented Jan 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sgammon sgammon merged commit 1408425 into main Jan 1, 2024
66 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working native-image Features and issues relating to the Native Image tool platform:darwin Issues relating to macOS platform:linux Issues and features relating to Linux platform:windows Issues relating to Windows and MSVC
Projects
Development

Successfully merging this pull request may close these issues.

Shared library build output bug
1 participant