Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bazelci support #259

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: bazelci support #259

merged 1 commit into from
Jan 16, 2024

Conversation

sgammon
Copy link
Owner

@sgammon sgammon commented Jan 16, 2024

Summary

Fixes for Bazel CI support, which surfaced in bazelbuild/continuous-integration#1724.

Changelog

  • fix: drop bcr test module stanza from bazelci config
  • fix: add build/test targets to run in bazelci

- fix: drop bcr test module stanza from bazelci config
- fix: add build/test targets to run in bazelci

Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon sgammon added bug Something isn't working bazelci Bazel CI issues and support labels Jan 16, 2024
@sgammon sgammon added this to the 1.0.0 milestone Jan 16, 2024
@sgammon sgammon self-assigned this Jan 16, 2024
@sgammon sgammon marked this pull request as ready for review January 16, 2024 21:01
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sgammon
Copy link
Owner Author

sgammon commented Jan 16, 2024

@meteorcloudy I think this should do it, right? I've tested the build/test commands described in the CI config locally, and they run fine. I'll merge and see if this revision helps; if there's a way to manually test/run Bazel-style CI, let me know and I can follow those steps.

@sgammon sgammon merged commit d3b7e83 into main Jan 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazelci Bazel CI issues and support bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

1 participant