Fixes LLVM references to get build to work #307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganasherjones
force-pushed
the
fix-llvm-references
branch
2 times, most recently
from
805a126
to
034161d
Compare
loganasherjones
changed the title
Signed-off-by: loganasherjones <loganasherjones@gmail.com>
loganasherjones
force-pushed
the
fix-llvm-references
branch
from
034161d
to
8162427
Compare
|
sgammon
approved these changes
Feb 19, 2024
|
Thanks for contributing; and thank you as well for filing these separately, making for much easier review. |
|
Going to merge #308 as it includes these changes and doesn't need a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm interested in contributing this feature, but in order to get everything to build locally, I had to update to use the new llvm toolchain located here.