fix: support macos minimum version #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruairidh Williamson <ruairidh.williamson@nextdlp.com>
ruwi-next
force-pushed
the
fix/support-macos-min-ver
branch
from
f110d7f
to
4ba839d
Compare
|
sgammon
approved these changes
May 10, 2024
There was a problem hiding this comment.
Hi @ruwi-next, Thank you for the clear explanation and PR! 👍
sgammon
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Summary
When building for macOS it is often required to set
--macos_minimum_osto specify the minimum os version to build for. Running a binary on an os built for a later os could mean it could crash when trying to resolve symbols not in this os release. Not setting this will default to the build machine's os version.Using this with rules_graalvm does not work as you can see when setting
--macos_minimum_os=11.0and runningotool -l ./bin | grep -B1 -A3 MIN_MAC.The solution is to set env var
MACOSX_DEPLOYMENT_TARGETfor xcode to pick up as documented here https://github.com/clj-easy/graal-docs?tab=readme-ov-file#targeting-a-minimum-macos-versionThanks