lint: golangci new version fixes

.golangci.yml

@@ -3,7 +3,6 @@ run:
   timeout: 15m
   sort-results: true
   allow-parallel-runners: true
-  exclude-dir: testutil/testdata_pulsar
   concurrency: 4
 
 linters:
@@ -48,7 +47,16 @@ linters:
     - revive
 
 issues:
-  exclude-rules: []
+  exclude-rules: 
+    - path: (.+)_test.go
+      linters: 
+        - gosec
+    - path: suite.go
+      linters: 
+        - gosec
+    - path: testutil
+      linters: 
+        - gosec
   max-issues-per-linter: 10000
   max-same-issues: 10000
 

app/upgrades/v10/upgrades.go

@@ -13,7 +13,7 @@ func CreateUpgradeHandler(
 	configurator module.Configurator,
 	_ *keepers.AppKeepers,
 ) upgradetypes.UpgradeHandler {
-	return func(ctx sdk.Context, plan upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
+	return func(ctx sdk.Context, _ upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
 		return mm.RunMigrations(ctx, configurator, fromVM)
 	}
 }

app/upgrades/v9/upgrades.go

@@ -43,12 +43,10 @@ func CreateUpgradeHandler(
 	configurator module.Configurator,
 	k *keepers.AppKeepers,
 ) upgradetypes.UpgradeHandler {
-	return func(ctx sdk.Context, plan upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
+	return func(ctx sdk.Context, _ upgradetypes.Plan, fromVM module.VersionMap) (module.VersionMap, error) {
 		// https://github.com/cosmos/cosmos-sdk/pull/12363/files
 		// Set param key table for params module migration
 		for _, subspace := range k.ParamsKeeper.GetSubspaces() {
-			subspace := subspace
-
 			var keyTable paramstypes.KeyTable
 			switch subspace.Name() {
 			case authtypes.ModuleName:

cmd/sged/cmd/genaccounts_test.go

@@ -61,7 +61,6 @@ func TestSampleCMD(t *testing.T) {
 			args: []string{},
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			var args []string
 

tests/e2e/bet/grpc.go

@@ -94,7 +94,6 @@ func (s *E2ETestSuite) TestBetsGRPCHandler() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			resp, err := testutil.GetRequestWithHeaders(tc.url, tc.headers)
 			s.Require().NoError(err)

tests/e2e/bet/suite.go

@@ -369,8 +369,6 @@ func (s *E2ETestSuite) TestWagerTxCmd() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Require().NoError(s.network.WaitForNextBlock())
 		s.Run(tc.name, func() {
 			ticket, err := simapp.CreateJwtTicket(tc.ticketClaims)

tests/e2e/house/grpc.go

@@ -54,7 +54,6 @@ func (s *E2ETestSuite) TestDepositsGRPCHandler() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			resp, err := testutil.GetRequestWithHeaders(tc.url, tc.headers)
 			s.Require().NoError(err)
@@ -93,7 +92,6 @@ func (s *E2ETestSuite) TestGRPCHandler() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			resp, err := testutil.GetRequestWithHeaders(tc.url, tc.headers)
 			s.Require().NoError(err)

tests/e2e/house/suite.go

@@ -293,8 +293,6 @@ func (s *E2ETestSuite) TestDepositTxCmd() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Require().NoError(s.network.WaitForNextBlock())
 		s.Run(tc.name, func() {
 			ticket, err := simapp.CreateJwtTicket(tc.ticketClaims)
@@ -472,8 +470,6 @@ func (s *E2ETestSuite) TestDepositWithAuthzTxCmd() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Require().NoError(s.network.WaitForNextBlock())
 		s.Run(tc.name, func() {
 			ticket, err := simapp.CreateJwtTicket(tc.ticketClaims)
@@ -791,8 +787,6 @@ func (s *E2ETestSuite) TestWithdrawTxCmd() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Require().NoError(s.network.WaitForNextBlock())
 		s.Run(tc.name, func() {
 			ticket, err := simapp.CreateJwtTicket(tc.ticketClaims)
@@ -1000,8 +994,6 @@ func (s *E2ETestSuite) TestWithdrawWithAuthzTxCmd() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Require().NoError(s.network.WaitForNextBlock())
 		s.Run(tc.name, func() {
 			ticket, err := simapp.CreateJwtTicket(tc.ticketClaims)

tests/e2e/market/grpc.go

@@ -36,7 +36,6 @@ func (s *E2ETestSuite) TestMarketsGRPCHandler() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			resp, err := testutil.GetRequestWithHeaders(tc.url, tc.headers)
 			s.Require().NoError(err)

tests/e2e/market/suite.go

@@ -181,8 +181,6 @@ func (s *E2ETestSuite) TestMarketAddTxCmd() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Require().NoError(s.network.WaitForNextBlock())
 		s.Run(tc.name, func() {
 			ticket, err := simapp.CreateJwtTicket(tc.ticketClaims)

tests/e2e/reward/suite.go

@@ -174,8 +174,6 @@ func (s *E2ETestSuite) TestNewCampaignTxCmd() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Require().NoError(s.network.WaitForNextBlock())
 		s.Run(tc.name, func() {
 			clientCtx := val.ClientCtx

utils/fund.go

@@ -67,7 +67,7 @@ func (f *ModuleAccFunder) Refund(
 	// Transfer funds
 	err := f.bk.SendCoinsFromModuleToAccount(ctx, mAcc, receiverAcc, amt)
 	if err != nil {
-		return sdkerrors.Wrapf(f.bankError, err.Error())
+		return sdkerrors.Wrap(f.bankError, err.Error())
 	}
 
 	return nil

x/bet/client/cli/query_bet.go

@@ -18,7 +18,7 @@ func CmdListBet() *cobra.Command {
 		Use:   "bets",
 		Short: "get list of bets",
 		Long:  "Get list of bets in paginated response.",
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			clientCtx := client.GetClientContextFromCmd(cmd)
 
 			pageReq, err := client.ReadPageRequest(cmd.Flags())

x/bet/client/cli/query_bet_test.go

@@ -125,7 +125,6 @@ func TestQueryBet(t *testing.T) {
 				err:  status.Error(codes.NotFound, "not found"),
 			},
 		} {
-			tc := tc
 			t.Run(tc.desc, func(t *testing.T) {
 				args := []string{
 					tc.creator,
@@ -371,7 +370,6 @@ func TestQueryBet(t *testing.T) {
 				obj:  objs,
 			},
 		} {
-			tc := tc
 			t.Run(tc.desc, func(t *testing.T) {
 				args := []string{
 					strings.Join(tc.items, ","),

x/bet/client/cli/query_params.go

@@ -17,7 +17,7 @@ func CmdQueryParams() *cobra.Command {
 		Use:   "params",
 		Short: "shows the parameters of the module",
 		Args:  cobra.NoArgs,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			clientCtx := client.GetClientContextFromCmd(cmd)
 
 			queryClient := types.NewQueryClient(clientCtx)

x/bet/client/cli/query_test.go

@@ -30,7 +30,6 @@ func TestGetQueryCmd(t *testing.T) {
 			args: []string{},
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			var args []string
 

x/bet/client/cli/tx_bet_test.go

@@ -65,7 +65,6 @@ func TestTXBetCLI(t *testing.T) {
 				err:  fmt.Errorf("any error"),
 			},
 		} {
-			tc := tc
 			t.Run(tc.desc, func(t *testing.T) {
 				args := []string{
 					tc.uid,

x/bet/client/cli/tx_test.go

@@ -28,7 +28,6 @@ func TestGetTxCmd(t *testing.T) {
 			args: []string{},
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			var args []string
 

x/bet/keeper/grpc_query_bet.go

@@ -32,7 +32,7 @@ func (k Keeper) Bets(c context.Context, req *types.QueryBetsRequest) (*types.Que
 
 	betStore := prefix.NewStore(ctx.KVStore(k.storeKey), types.BetListPrefix)
 
-	pageRes, err := query.Paginate(betStore, req.Pagination, func(key, value []byte) error {
+	pageRes, err := query.Paginate(betStore, req.Pagination, func(_, value []byte) error {
 		var bet types.Bet
 		if err := k.cdc.Unmarshal(value, &bet); err != nil {
 			return err
@@ -62,7 +62,7 @@ func (k Keeper) BetsByCreator(
 
 	betStore := prefix.NewStore(ctx.KVStore(k.storeKey), types.BetListByCreatorPrefix(req.Creator))
 
-	pageRes, err := query.Paginate(betStore, req.Pagination, func(key, value []byte) error {
+	pageRes, err := query.Paginate(betStore, req.Pagination, func(_, value []byte) error {
 		var bet types.Bet
 		if err := k.cdc.Unmarshal(value, &bet); err != nil {
 			return err
@@ -153,7 +153,7 @@ func (k Keeper) PendingBets(
 	pageRes, err := query.Paginate(
 		pendingBetStore,
 		req.Pagination,
-		func(key, value []byte) error {
+		func(_, value []byte) error {
 			var pendingBet types.PendingBet
 			if err := k.cdc.Unmarshal(value, &pendingBet); err != nil {
 				return err
@@ -197,7 +197,7 @@ func (k Keeper) SettledBetsOfHeight(
 	pageRes, err := query.Paginate(
 		settledBetStore,
 		req.Pagination,
-		func(key, value []byte) error {
+		func(_, value []byte) error {
 			var settledBet types.SettledBet
 			if err := k.cdc.Unmarshal(value, &settledBet); err != nil {
 				return err

x/bet/simulation/bet.go

@@ -21,7 +21,7 @@ func SimulateMsgWager(
 	bk types.BankKeeper,
 	k keeper.Keeper,
 ) simtypes.Operation {
-	return func(r *rand.Rand, app *baseapp.BaseApp, ctx sdk.Context, accs []simtypes.Account, chainID string,
+	return func(r *rand.Rand, app *baseapp.BaseApp, ctx sdk.Context, accs []simtypes.Account, _ string,
 	) (simtypes.OperationMsg, []simtypes.FutureOperation, error) {
 		simAccount, _ := simtypes.RandomAcc(r, accs)
 

x/bet/simulation/decoder_test.go

@@ -81,7 +81,6 @@ func TestDecodeStore(t *testing.T) {
 	}
 
 	for i, tt := range tests {
-		i, tt := i, tt
 		t.Run(tt.name, func(t *testing.T) {
 			switch i {
 			case len(tests) - 1:

x/bet/simulation/proposals.go

@@ -8,6 +8,7 @@ import (
 	"github.com/cosmos/cosmos-sdk/types/address"
 	simtypes "github.com/cosmos/cosmos-sdk/types/simulation"
 	"github.com/cosmos/cosmos-sdk/x/simulation"
+	"github.com/spf13/cast"
 
 	"github.com/sge-network/sge/x/bet/types"
 )
@@ -36,11 +37,11 @@ func SimulateMsgUpdateParams(r *rand.Rand, _ sdk.Context, _ []simtypes.Account)
 	var authority sdk.AccAddress = address.Module("gov")
 
 	params := types.DefaultParams()
-	params.BatchSettlementCount = uint32(r.Intn(10000))
-	params.MaxBetByUidQueryCount = uint32(r.Intn(1000))
+	params.BatchSettlementCount = cast.ToUint32(r.Intn(10000))
+	params.MaxBetByUidQueryCount = cast.ToUint32(r.Intn(1000))
 	params.Constraints = types.Constraints{
-		MinAmount: sdkmath.NewInt(int64(r.Intn(1000))),
-		Fee:       sdkmath.NewInt(int64(r.Intn(99))),
+		MinAmount: sdkmath.NewInt(cast.ToInt64(r.Intn(1000))),
+		Fee:       sdkmath.NewInt(cast.ToInt64(r.Intn(99))),
 	}
 
 	return &types.MsgUpdateParams{

x/house/client/cli/query_deposit.go

@@ -29,7 +29,7 @@ $ %s query house deposits
 				version.AppName,
 			),
 		),
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			clientCtx, err := client.GetClientQueryContext(cmd)
 			if err != nil {
 				return err

x/house/client/cli/query_params.go

@@ -17,7 +17,7 @@ func CmdQueryParams() *cobra.Command {
 		Use:   "params",
 		Short: "shows the parameters of the module",
 		Args:  cobra.NoArgs,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			clientCtx := client.GetClientContextFromCmd(cmd)
 
 			queryClient := types.NewQueryClient(clientCtx)

x/house/client/cli/query_params_test.go

@@ -29,7 +29,6 @@ func TestQueryParams(t *testing.T) {
 			args: []string{},
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			var args []string
 			args = append(args, tc.args...)

x/house/client/cli/query_test.go

@@ -30,7 +30,6 @@ func TestGetQueryCmd(t *testing.T) {
 			args: []string{},
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			var args []string
 			args = append(args, tc.args...)

x/house/client/cli/tx_deposit_test.go

@@ -65,7 +65,6 @@ func TestTXDepositCLI(t *testing.T) {
 				err:  fmt.Errorf("any error"),
 			},
 		} {
-			tc := tc
 			t.Run(tc.desc, func(t *testing.T) {
 				args := []string{
 					tc.marketUID,

x/house/client/cli/tx_test.go

@@ -28,7 +28,6 @@ func TestGetTxCmd(t *testing.T) {
 			args: []string{},
 		},
 	} {
-		tc := tc
 		t.Run(tc.desc, func(t *testing.T) {
 			var args []string
 			args = append(args, tc.args...)

x/house/client/cli/tx_withdraw.go

@@ -45,13 +45,13 @@ func CmdWithdraw() *cobra.Command {
 
 			argTicket := args[2]
 
-			mode, err := cast.ToInt64E(args[3])
+			mode, err := cast.ToInt32E(args[3])
 			if err != nil {
 				return fmt.Errorf("mode provided must be a non-negative-integer: %v", mode)
 			}
 
 			var argAmountCosmosInt sdkmath.Int
-			if mode == int64(types.WithdrawalMode_WITHDRAWAL_MODE_PARTIAL) {
+			if mode == int32(types.WithdrawalMode_WITHDRAWAL_MODE_PARTIAL) {
 				if len(args) != 5 {
 					return fmt.Errorf("amount is mandatory for partial mode")
 				}

x/house/client/cli/tx_withdraw_test.go

@@ -70,7 +70,6 @@ func TestTXWithdrawCLI(t *testing.T) {
 				err:  fmt.Errorf("any error"),
 			},
 		} {
-			tc := tc
 			t.Run(tc.desc, func(t *testing.T) {
 				args := []string{
 					tc.marketUID,

x/house/keeper/grpc_query_deposit.go

@@ -27,7 +27,7 @@ func (k Keeper) Deposits(
 	ctx := sdk.UnwrapSDKContext(c)
 
 	store := k.getDepositStore(ctx)
-	pageRes, err := query.Paginate(store, req.Pagination, func(key, value []byte) error {
+	pageRes, err := query.Paginate(store, req.Pagination, func(_, value []byte) error {
 		var deposit types.Deposit
 		if err := k.cdc.Unmarshal(value, &deposit); err != nil {
 			return err
@@ -55,7 +55,7 @@ func (k Keeper) DepositsByAccount(c context.Context,
 	ctx := sdk.UnwrapSDKContext(c)
 
 	store := prefix.NewStore(k.getDepositStore(ctx), types.GetDepositListPrefix(req.Address))
-	pageRes, err := query.Paginate(store, req.Pagination, func(key, value []byte) error {
+	pageRes, err := query.Paginate(store, req.Pagination, func(_, value []byte) error {
 		var deposit types.Deposit
 		if err := k.cdc.Unmarshal(value, &deposit); err != nil {
 			return err

x/house/keeper/grpc_query_withdrawal.go

@@ -26,7 +26,7 @@ func (k Keeper) WithdrawalsByAccount(c context.Context,
 	ctx := sdk.UnwrapSDKContext(c)
 
 	store := prefix.NewStore(k.getWithdrawalStore(ctx), types.GetWithdrawalListPrefix(req.Address))
-	pageRes, err := query.Paginate(store, req.Pagination, func(key, value []byte) error {
+	pageRes, err := query.Paginate(store, req.Pagination, func(_, value []byte) error {
 		var withdrawal types.Withdrawal
 		if err := k.cdc.Unmarshal(value, &withdrawal); err != nil {
 			return err