Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit/subaccount #256

Merged
merged 15 commits into from
Sep 21, 2023

Conversation

scorpioborn
Copy link
Contributor

@scorpioborn scorpioborn commented Sep 20, 2023

Description

Refactor subaccount module to match the rest of the modules' design.


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • Subaccount module refactor.
  • Replace time with epoch timestamp in the balance.
  • Remove duplicate logic of bet ticket parse.
  • Use cosmossdk.io types

Test Cases

  • NA

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@scorpioborn scorpioborn marked this pull request as ready for review September 21, 2023 07:01
@scorpioborn scorpioborn requested review from 3eyedraga and a team as code owners September 21, 2023 07:01
@scorpioborn scorpioborn changed the base branch from feature/subaccount to feature/rewards-subaccount September 21, 2023 08:21
@scorpioborn scorpioborn changed the base branch from feature/rewards-subaccount to feature/subaccount September 21, 2023 08:54
@3eyedraga 3eyedraga merged commit 72aaa51 into sge-network:feature/subaccount Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants