Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Reward grant validations #290

Merged

Conversation

scorpioborn
Copy link
Contributor

Description

The Grant Grant reward validations have been added to the validations.


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • NA

Test Cases

  • NA

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@3eyedraga 3eyedraga changed the base branch from feature/campaigntx_mod to feature/rewards November 9, 2023 08:40
@github-actions github-actions bot added the C:CLI label Nov 9, 2023
@scorpioborn scorpioborn marked this pull request as ready for review November 9, 2023 09:57
@scorpioborn scorpioborn requested review from 3eyedraga and a team as code owners November 9, 2023 09:57
@3eyedraga 3eyedraga merged commit c2edd78 into sge-network:feature/rewards Nov 9, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants