Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Referral Signup and Referral (#321) #324

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

scorpioborn
Copy link
Contributor

  • feat: signup referrer logic

  • rename: referrer to referee in the ticket payload

  • refactor: remove reward pair

  • format: reformat proto files

  • fix: inclue referral and referee campaign in the factory

  • feat: check existing category receiver for the referee

  • feat: validate source uid for the referee signup

  • feat: validations for signup referral

Description


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • NA

Test Cases

  • NA

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

* feat: signup referrer logic

* rename: referrer to referee in the ticket payload

* refactor: remove reward pair

* format: reformat proto files

* fix: inclue referral and referee campaign in the factory

* feat: check existing category receiver for the referee

* feat: validate source uid for the referee signup

* feat: validations for signup referral
@scorpioborn scorpioborn requested review from 3eyedraga and a team as code owners December 15, 2023 05:59
@codecov-commenter
Copy link

Codecov Report

Attention: 246 lines in your changes are missing coverage. Please review.

Comparison is base (87db989) 11.83% compared to head (f2ba9ca) 11.79%.

Files Patch % Lines
x/reward/types/ticket.pb.go 0.71% 139 Missing ⚠️
x/reward/types/reward_signup_referee.go 0.00% 35 Missing ⚠️
x/reward/types/reward_signup_referrer.go 0.00% 32 Missing ⚠️
x/reward/types/reward_signup.go 0.00% 19 Missing ⚠️
x/reward/types/reward.go 0.00% 15 Missing ⚠️
x/reward/types/campaign.go 0.00% 4 Missing ⚠️
x/reward/keeper/msg_server_reward.go 83.33% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   11.83%   11.79%   -0.04%     
==========================================
  Files         346      348       +2     
  Lines       44417    44642     +225     
==========================================
+ Hits         5257     5267      +10     
- Misses      38679    38894     +215     
  Partials      481      481              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3eyedraga 3eyedraga changed the base branch from master to feature/referral-rewards December 18, 2023 14:19
@3eyedraga 3eyedraga merged commit e9bf56c into feature/referral-rewards Dec 18, 2023
22 checks passed
@3eyedraga 3eyedraga deleted the feature/signup-referral branch December 18, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants