Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade / v1.6.2 #391

Merged
merged 5 commits into from
May 6, 2024
Merged

Upgrade / v1.6.2 #391

merged 5 commits into from
May 6, 2024

Conversation

scorpioborn
Copy link
Contributor

@scorpioborn scorpioborn commented Apr 25, 2024

Description

Replace Cosmos-SDK fork with the latest tempfix for the validator margin error.


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • Replace Cosmos-SDK fork commit hash
  • Replace sdk.Int with sdkmath.Int
  • Update upgrade handler

Test Cases

  • NA

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@scorpioborn scorpioborn changed the title Upgrade / Promoter Category with UID Upgrade / v1.6.2 Apr 29, 2024
@scorpioborn scorpioborn marked this pull request as ready for review April 29, 2024 14:37
@scorpioborn scorpioborn requested a review from a team as a code owner April 29, 2024 14:37
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 35.71429% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 11.10%. Comparing base (6110522) to head (fd1ab06).
Report is 18 commits behind head on master.

Files Patch % Lines
x/orderbook/types/participation.go 0.00% 10 Missing ⚠️
x/reward/keeper/reward.go 0.00% 9 Missing ⚠️
x/bet/types/params.go 0.00% 0 Missing and 2 partials ⚠️
x/orderbook/types/exposure.go 0.00% 2 Missing ⚠️
x/house/types/params.go 0.00% 0 Missing and 1 partial ⚠️
x/house/types/withdraw_authorizaton.go 0.00% 0 Missing and 1 partial ⚠️
x/orderbook/keeper/bet_wager.go 66.66% 0 Missing and 1 partial ⚠️
x/reward/types/campaign_authorizaton.go 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
- Coverage   11.10%   11.10%   -0.01%     
==========================================
  Files         359      359              
  Lines       48561    48675     +114     
==========================================
+ Hits         5394     5406      +12     
- Misses      42678    42778     +100     
- Partials      489      491       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3eyedraga 3eyedraga merged commit b7c0eab into master May 6, 2024
22 checks passed
@3eyedraga 3eyedraga deleted the upgrade/promoter-category branch May 6, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants