-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playvideos: improves Content-Security-Policy (CSP) compliance #2110
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're at it, couldn't we automate the download of https://code.jquery.com/jquery-3.7.1.min.js during frontend builds? Instead of vendoring a massive minified js file
Good idea, just I am not aware on how to make it work (yet?) but I approve this. |
I guess the plugin could be rewritten to discard usage of jquery, nowadays, no? I am not a Web dev so I might be wrong ;-) However I am a bit lost with the frontend build usage, I managed to integrate jquery with the correct version and verified its fingerprints, but is it okay then I load the JS script from its path |
e94cd36
to
f442975
Compare
f442975
to
b504e79
Compare
b504e79
to
41a1c28
Compare
Signed-off-by: Thibaud CANALE <thican@thican.net>
Signed-off-by: Thibaud CANALE <thican@thican.net>
Improves situation for #1513.
I hope it can integrate milestone
0.14.0
(#2105).