Skip to content

Commit

Permalink
feat: harmonize user interface (#387)
Browse files Browse the repository at this point in the history
* feat: add nav to source view

* fix: replace link colors

* feat: clean up nav

* feat: clean up source view

* build: remove unused components and libraries

* feat: globalize outline style

* feat: clean up line view

* feat: use layout for source view

* feat: unify ascii gurmukhi in new component

* refactor: remove unused property

* feat: improve mobile experience

* fix: correct paths in manifest.json

* feat: harmonize content start position across screens

* feat: make hotkeys cross-platform and document in about screen

the ctrl arrow hotkey doesn't work on mac

* feat: hide vishraams from all gurmukhi

* feat: match font sizes in nav bar

* fix: remove non-existing test

* fix: remove vishraams from tests

* fix: match cy properties
  • Loading branch information
bhajneet authored Jun 13, 2022
1 parent 3dcddf8 commit 7b79b61
Show file tree
Hide file tree
Showing 29 changed files with 430 additions and 911 deletions.
13 changes: 0 additions & 13 deletions cypress/integration/gh-issue-open.spec.ts

This file was deleted.

12 changes: 6 additions & 6 deletions cypress/integration/main.spec.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
describe( 'Source: SGGS', () => {
it( 'Open Source Page', () => {
cy.visit( '/sources/1/page/1/line/0' )
cy.contains( '<> siq nwmu krqw purKu inrBau inrvYru; Akwl mUriq AjUnI sYBM gur pRswid ]' ).click()
cy.contains( '<> siq nwmu krqw purKu inrBau inrvYru Akwl mUriq AjUnI sYBM gur pRswid ]' ).click()
} )

it( 'Open Line Viewer', () => cy.goToLineViewer( 'Prof. Sahib Singh' ) )
Expand All @@ -19,22 +19,22 @@ describe( 'Source: Sri Dasam Granth', () => {

it( 'Open Line Viewer', () => cy.goToLineViewer( 'Dr. Rattan Singh Jaggi' ) )

it( 'Go to Next Line', () => cy.goToNextLine( 'ByK;' ) )
it( 'Go to Next Line', () => cy.goToNextLine( 'ByK' ) )

it( 'Go back home', () => cy.goToSourceView( 'iqRBvx mhIp, sur, nr, Asur; nyq nyq bn iqRx khq ]' ) )
it( 'Go back home', () => cy.goToSourceView( 'iqRBvx mhIp sur nr Asur nyq nyq bn iqRx khq ]' ) )
} )

describe( 'Source: Vaaran', () => {
it( 'Open Source Page', () => {
cy.visit( '/sources/3/page/1/line/0' )
cy.contains( 'ipRQmY swis n mws sin; AMD DuMD kCu Kbir n pweI [' ).click()
cy.contains( 'ipRQmY swis n mws sin AMD DuMD kCu Kbir n pweI [' ).click()
} )

it( 'Open Line Viewer', () => cy.goToLineViewer( 'Bhai Vir Singh' ) )

it( 'Go to Next Line', () => cy.goToNextLine( 'ibMd' ) )

it( 'Go back home', () => cy.goToSourceView( 'rkiq ibMd kI dyih ric; pMic qq kI jiVq jVweI [' ) )
it( 'Go back home', () => cy.goToSourceView( 'rkiq ibMd kI dyih ric pMic qq kI jiVq jVweI [' ) )
} )

describe( 'Source: Kabit Swaiye', () => {
Expand Down Expand Up @@ -108,7 +108,7 @@ describe( 'Source: Ardaas', () => {

it( 'Open Line Viewer', () => cy.goToLineViewer( 'SGPC' ) )

it( 'Go back home', () => cy.goToSourceView( 'is`KW dw mn nIvW, mq au~cI, mq dw rwKw Awip vwihgurU [' ) )
it( 'Go back home', () => cy.goToSourceView( 'is`KW dw mn nIvW mq au~cI mq dw rwKw Awip vwihgurU [' ) )
} )

describe( 'Source: Sarabloh Granth', () => {
Expand Down
2 changes: 1 addition & 1 deletion cypress/support/commands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Cypress.Commands.add( 'matchValue', ( location, matchValue ) => {

Cypress.Commands.add( 'goToNextLine', ( matchValue ) => {
cy.get( '[data-cy=go-to-next-line-button]' ).click()
cy.matchValue( 'h1', matchValue )
cy.matchValue( '[data-cy=source-line]', matchValue )
} )

Cypress.Commands.add( 'goToSourceView', ( matchValue ) => {
Expand Down
167 changes: 0 additions & 167 deletions frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 7b79b61

Please sign in to comment.