Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www): Update Form component type definitions and context handling #5892

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

guesung
Copy link

@guesung guesung commented Nov 21, 2024

Description

Fixed type-related issues in Form component:

  • Updated FormItemContext to properly handle null initial value
  • Added itemContext check in useFormField condition
  • Removed unnecessary type assertion in context creation

These changes improve type safety and prevent potential runtime errors.

Copy link

vercel bot commented Nov 21, 2024

@guesung is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@guesung guesung changed the title fix: Update Form component type definitions and context handling fix(www): Update Form component type definitions and context handling Nov 21, 2024
Copy link
Contributor

@Jacksonmills Jacksonmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to run pnpm build:registry

@guesung
Copy link
Author

guesung commented Nov 21, 2024

@Jacksonmills

Thank you for the reminder. I ran pnpm build:registry and pushed the updated changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants