fix(shadcn): Select asChild
prop is unsupported
#5905
+22
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of issue
Using the
<SelectTrigger>
component with theasChild
prop results in the following error:This is due to the
<ChevronDown>
icon being included as second descendant of<SelectTrigger>
, even whenasChild
isTRUE
.asChild
requires that there is only one descendant.Solution
Conditionally render
<ChevronDown>
inside a fragment that includes{children}
ifprops.asChild
is not set. Ifprops.asChild
is set, then simply render{children}
. There are no visual changes with this solution.Notes
This is my first contribution to shadcn/ui - let me know if I'm missing any details! I could not find any existing issue reports for this.