cleanup on asserts

shader-slang · Dec 9, 2024 · 3adc914 · 3adc914
1 parent 220a97b
commit 3adc914
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/source/slang/slang-check-modifier.cpp b/source/slang/slang-check-modifier.cpp
@@ -1505,7 +1505,6 @@ AttributeBase* SemanticsVisitor::checkGLSLLayoutAttribute(
         {
             uncheckedAttr->args.add(uncheckedAttr->args[0]);
             uncheckedAttr->args[0] = nullptr;
-            SLANG_ASSERT(uncheckedAttr->args[1] != nullptr);
         }
 
         SLANG_ASSERT(uncheckedAttr->args.getCount() == 2);
@@ -2043,13 +2042,13 @@ void SemanticsVisitor::checkModifiers(ModifiableSyntaxNode* syntaxNode)
             }
             else
             {
-                const auto constVal = checkConstantIntVal(glslOffsetAttribute->args[0]);
-                SLANG_ASSERT(constVal != nullptr);
-
-                glslOffsetAttribute->offset = uint64_t(constVal->getValue());
-                getGLSLBindingOffsetTracker()->setBindingOffset(
-                    glslBindingAttribute->binding,
-                    glslOffsetAttribute->offset);
+                if (const auto constVal = checkConstantIntVal(glslOffsetAttribute->args[0]))
+                {
+                    glslOffsetAttribute->offset = uint64_t(constVal->getValue());
+                    getGLSLBindingOffsetTracker()->setBindingOffset(
+                        glslBindingAttribute->binding,
+                        glslOffsetAttribute->offset);
+                }
             }
         }
         else