Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable WGSL tests that works for Metal related to Semantics #5816

Conversation

jkwak-work
Copy link
Collaborator

This commit enables existing tests for WGSL that are enabled for Metal regarding the Semantics.

Closes #5502

@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Dec 10, 2024
@jkwak-work jkwak-work self-assigned this Dec 10, 2024
@jkwak-work jkwak-work requested a review from a team as a code owner December 10, 2024 02:11
csyonghe
csyonghe previously approved these changes Dec 10, 2024
@aleino-nv
Copy link
Collaborator

Just FYI, the commit message says "WGSP" instead of "WGSL".

@jkwak-work jkwak-work changed the title Enable WGSP tests that works for Metal related to Semantics Enable WGSL tests that works for Metal related to Semantics Dec 10, 2024
This commit enables existing tests for WGSL that are enabled for Metal regarding the Semantics.
@jkwak-work jkwak-work force-pushed the test/enable_wgsl_test_for_nested_struct_fragment_input branch from 507837e to 077ff36 Compare December 10, 2024 16:27
@jkwak-work
Copy link
Collaborator Author

Just FYI, the commit message says "WGSP" instead of "WGSL".

Thanks for the review.
I didn't realize that you already enabled a few of them.

@jkwak-work jkwak-work merged commit f0b9914 into shader-slang:master Dec 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WGSL] Enable semantic related tests that work already for Metal
3 participants