Bump spirv-header/tools/glslang #5834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwak-work
reviewed
Dec 11, 2024
|
I see that the real fix is placed on KhronosGroup repo. |
|
Closing this one because we landed #5815. |
expipiplus1
force-pushed
the
push-xkllnnkkpkzv
branch
2 times, most recently
from
b93d9cf to
42b0149
Compare
Supersedes shader-slang#5815
Note that this currently fails validation with the following error: ``` error: line 145: Result <id> from OpSampledImage instruction must not appear as operand for OpImageSampleFootprintNV, since it is not specified as taking an OpTypeSampledImage. Found result <id> '55[%sampledImage]' as an operand of <id> '56[%resultVal]'. %sampledImage = OpSampledImage %54 %51 %40 ``` This seems to be in error as the spec for *SPV_NV_shader_image_footprint* states that "Sampled Image must be an object whose type is OpTypeSampledImage" https://refined-github-html-preview.kidonng.workers.dev/KhronosGroup/SPIRV-Registry/raw/refs/heads/main/extensions/NV/SPV_NV_shader_image_footprint.html glslang also seems to fail with the same validation error
expipiplus1
force-pushed
the
push-xkllnnkkpkzv
branch
from
42b0149 to
43ed943
Compare
csyonghe
previously approved these changes
Dec 12, 2024
|
This seemed to be exposing a new test failure. |
Yeah, glslang's output changed order of some decorations, easy fix |
csyonghe
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #5815
This PR also moves us back onto upstream spirv-tools/glslang, as our branches just had a bunch of empty merges.
This uses my patched version of spirv-tools KhronosGroup/SPIRV-Tools@
2b315c2(#5914) which closes KhronosGroup/SPIRV-Tools#5913I suggest we wait until my PR (KhronosGroup/SPIRV-Tools#5914) is merged , or KhronosGroup/SPIRV-Tools#5913 is otherwise fixed