Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(giveaway): host member is undefined on giveaway start #4

Merged
merged 1 commit into from
Oct 28, 2023
Merged

fix(giveaway): host member is undefined on giveaway start #4

merged 1 commit into from
Oct 28, 2023

Conversation

zimzika
Copy link
Contributor

@zimzika zimzika commented Oct 26, 2023

change method to get host member of the giveaway from cache to fetch, in my case the owner of giveaway is not included in cache of discord client users resulting in undefined on defineEmbedStrings

@shadowplay1
Copy link
Owner

shadowplay1 commented Oct 26, 2023

are the changes tested and are fixing the problem?

@zimzika
Copy link
Contributor Author

zimzika commented Oct 27, 2023

are the changes tested and are fixing the problem?

Yes fix the problem, but i don't make several tests.

@shadowplay1
Copy link
Owner

Test it a bit more, make changes if needed and I will merge, thanks for taking time and fixing the bug :)

@zimzika
Copy link
Contributor Author

zimzika commented Oct 27, 2023

Test it a bit more, make changes if needed and I will merge, thanks for taking time and fixing the bug :)

I'm tested and works fine! I'm glad I could help 😃

@shadowplay1 shadowplay1 merged commit ace68d3 into shadowplay1:main Oct 28, 2023
2 checks passed
@shadowplay1
Copy link
Owner

shadowplay1 commented Oct 28, 2023

merged 👍
appreciate you taking time on this, thank you :)

@shadowplay1 shadowplay1 changed the title fix host member undefined on start new giveaway fix(giveaway): host member is undefined on giveaway start Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants