Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cli update multiple rfox staking contracts #95

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaladinlight
Copy link
Contributor

DO NOT MERGE

This PR updates the CLI to handle multiple staking contracts for rFOX along with migrating the existing IPFS data structure to the new format.

TODO:

  • Asset spot price for LP token
  • Update ARBITRUM_RFOX_PROXY_CONTRACT_ADDRESS_UNIV2_ETH_FOX with final proxy contract for lp staking
  • Validate process and distribution flows
  • Audit IPFS data structure

Migration Steps:

  • Run the cli and use Migrate rFOX metadata action pointing to the most recent rFOX metadata IPFS hash
  • Update web with the new IPFS data structure (types and associated logic)
  • Point web to the new migrated rFOX metadata IPFS hash

@kaladinlight kaladinlight linked an issue Nov 12, 2024 that may be closed by this pull request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. I was trying to think if there is any additional meta data the front end might need about the contracts and the underlying tokens, but that seems like its all discoverable and doesn't need to be a part of the IPFS data that we store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend CLI tooling for additional rFOX pool (FOX<>ETH LP)
2 participants