fix: dont require account number when getting a quote

shapeshift · Nov 7, 2024 · 0e299a9 · 0e299a9
1 parent 8d77d56
commit 0e299a9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 16 deletions.
diff --git a/packages/swapper/src/types.ts b/packages/swapper/src/types.ts
@@ -138,15 +138,13 @@ type CommonTradeInputBase = {
 
 export type CommonTradeQuoteInput = CommonTradeInputBase & {
   sendAddress?: string
-  receiveAccountNumber?: number
   receiveAddress: string
   accountNumber: number
   quoteOrRate: 'quote'
 }
 
 type CommonTradeRateInput = CommonTradeInputBase & {
   sendAddress?: undefined
-  receiveAccountNumber?: undefined
   receiveAddress: undefined
   accountNumber: undefined
   quoteOrRate: 'rate'
@@ -253,7 +251,6 @@ type TradeQuoteBase = {
   id: string
   rate: string // top-level rate for all steps (i.e. output amount / input amount)
   receiveAddress: string | undefined // if receiveAddress is undefined, this is not a trade quote but a trade rate
-  receiveAccountNumber?: number
   potentialAffiliateBps: string // even if the swapper does not support affiliateBps, we need to zero-them out or view-layer will be borked
   affiliateBps: string // even if the swapper does not support affiliateBps, we need to zero-them out or view-layer will be borked
   isStreaming?: boolean

diff --git a/src/components/MultiHopTrade/hooks/useGetTradeQuotes/getTradeQuoteInput.ts b/src/components/MultiHopTrade/hooks/useGetTradeQuotes/getTradeQuoteInput.ts
@@ -27,7 +27,6 @@ export type GetTradeQuoteInputArgs = {
   isSnapInstalled?: boolean
   pubKey?: string | undefined
   quoteOrRate: 'quote' | 'rate'
-  receiveAccountNumber?: number
   receiveAddress: string | undefined
   sellAccountNumber: number | undefined
   wallet: HDWallet | undefined
@@ -41,7 +40,6 @@ export const getTradeQuoteInput = async ({
   wallet,
   quoteOrRate,
   receiveAddress,
-  receiveAccountNumber,
   sellAmountBeforeFeesCryptoPrecision,
   allowMultiHop,
   affiliateBps,
@@ -80,18 +78,15 @@ export const getTradeQuoteInput = async ({
             })
           : undefined
 
-      if (
-        quoteOrRate === 'quote' &&
-        (receiveAccountNumber === undefined || receiveAddress === undefined)
-      )
-        throw new Error('missing receiveAccountNumber')
+      if (quoteOrRate === 'quote' && receiveAddress === undefined) {
+        throw new Error('missing receiveAddress')
+      }
 
       return {
         ...tradeQuoteInputCommonArgs,
         chainId: sellAsset.chainId as EvmChainId,
         supportsEIP1559: Boolean(supportsEIP1559),
         sendAddress,
-        receiveAccountNumber,
       } as GetTradeQuoteInput
     }
 
@@ -110,7 +105,6 @@ export const getTradeQuoteInput = async ({
         ...tradeQuoteInputCommonArgs,
         chainId: sellAsset.chainId as CosmosSdkChainId,
         sendAddress,
-        receiveAccountNumber,
       } as GetTradeQuoteInput
     }
 
@@ -170,7 +164,6 @@ export const getTradeQuoteInput = async ({
         ...tradeQuoteInputCommonArgs,
         chainId: sellAsset.chainId as CosmosSdkChainId,
         sendAddress,
-        receiveAccountNumber,
       } as GetTradeQuoteInput
     }
     default:

diff --git a/src/components/MultiHopTrade/hooks/useGetTradeQuotes/useGetTradeQuotes.tsx b/src/components/MultiHopTrade/hooks/useGetTradeQuotes/useGetTradeQuotes.tsx
@@ -216,8 +216,6 @@ export const useGetTradeQuotes = () => {
     }
     ;(async () => {
       const sellAccountNumber = sellAccountMetadata?.bip44Params?.accountNumber
-      const receiveAssetBip44Params = receiveAccountMetadata?.bip44Params
-      const receiveAccountNumber = receiveAssetBip44Params?.accountNumber
 
       const tradeAmountUsd = bnOrZero(sellAssetUsdRate).times(sellAmountCryptoPrecision)
 
@@ -238,7 +236,6 @@ export const useGetTradeQuotes = () => {
       const updatedTradeQuoteInput: GetTradeQuoteInput | undefined = await getTradeQuoteInput({
         sellAsset,
         sellAccountNumber,
-        receiveAccountNumber,
         sellAccountType: sellAccountMetadata?.accountType,
         buyAsset,
         wallet: wallet ?? undefined,